From: Jakub Jelinek <jakub@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] c++, v2: Drop TREE_READONLY on vars (possibly) initialized by tls wrapper [PR109164]
Date: Mon, 20 Mar 2023 20:26:06 +0100 [thread overview]
Message-ID: <ZBizTnJuBEo9k3AV@tucnak> (raw)
In-Reply-To: <70d76299-3cd0-6647-45c3-0aab6d21858a@redhat.com>
On Mon, Mar 20, 2023 at 03:15:32PM -0400, Jason Merrill wrote:
> > + else if (VAR_P (decl)
> > + && CP_DECL_THREAD_LOCAL_P (decl)
> > + && (!DECL_EXTERNAL (decl) || flag_extern_tls_init)
>
> Hmm, I wonder why we don't check the above line in var_needs_tls_wrapper?
It is tested in get_tls_init_fn (one of the 2 previous callers of
var_needs_tls_wrapper). No idea why it isn't in get_tls_wrapper_fn (the
other caller of it).
Jakub
next prev parent reply other threads:[~2023-03-20 19:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 17:51 [PATCH] c++: " Jakub Jelinek
2023-03-18 12:39 ` Jason Merrill
2023-03-18 12:54 ` Jakub Jelinek
2023-03-18 15:09 ` [PATCH] c++, v2: " Jakub Jelinek
2023-03-20 15:45 ` Jakub Jelinek
2023-03-20 19:15 ` Jason Merrill
2023-03-20 19:26 ` Jakub Jelinek [this message]
2023-03-20 19:28 ` Jason Merrill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZBizTnJuBEo9k3AV@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).