From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 33A1D3851ABE for ; Tue, 21 Mar 2023 08:23:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 33A1D3851ABE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679387015; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=eIrW9kwXdpkLS5eVyntsbcT2roGMMfQhTWgftPJUyYw=; b=ebFWoFhXIVHXytphtSoVhr9ASjt5VTcoxQb01Hrp+F/Ky4rK0tGisuT4fiQau7W7nTSL7I fRTyBk5+afPpU9iTEFckvwSZJQMzE64Hidfmwcxt2by5ZV8CYMkT7eKMs6We72queSpt8j QJPcUEau+8NejISnJdjjbyLgOzRGFNc= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-435-J-R_8DE2MMqaOPf2s6bMyw-1; Tue, 21 Mar 2023 04:23:32 -0400 X-MC-Unique: J-R_8DE2MMqaOPf2s6bMyw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D1498185A790; Tue, 21 Mar 2023 08:23:31 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7776440C6E67; Tue, 21 Mar 2023 08:23:31 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 32L8NS3V1122154 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 21 Mar 2023 09:23:29 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 32L8NSTt1122153; Tue, 21 Mar 2023 09:23:28 +0100 Date: Tue, 21 Mar 2023 09:23:27 +0100 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org, Jan Hubicka Subject: Re: [PATCH] tree-optimization/109170 - bogus use-after-free with __builtin_expect Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Mar 21, 2023 at 08:21:18AM +0000, Richard Biener wrote: > On Mon, 20 Mar 2023, Jakub Jelinek wrote: > > > On Mon, Mar 20, 2023 at 12:12:14PM +0000, Richard Biener wrote: > > > PR tree-optimization/109170 > > > * gimple-range-op.cc (cfn_pass_through_arg1): New. > > > (gimple_range_op_handler::maybe_builtin_call): Handle > > > __builtin_expect and similar via cfn_pass_through_arg1 > > > and inspecting the calls fnspec. > > > * builtins.cc (builtin_fnspec): Handle BUILT_IN_EXPECT > > > and BUILT_IN_EXPECT_WITH_PROBABILITY. > > > > I'm still worried about this builtins.cc change, can't we defer > > that part till GCC 14 where there will be enough time to see if it > > doesn't result in some undesirable problems (__builtin_expect* being > > optimized away when it still shouldn't etc.)? > > Sure. I've retested and pushed the following. Thanks. Jakub