From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0DB49385840E for ; Wed, 22 Mar 2023 10:34:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0DB49385840E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1679481286; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IS1BJxdnweltb5wdK/cWbBfodUHeSKzIyoYXwyaaZAo=; b=Yz3BgbCiHcaQddFyAEIlDo/hyS/DmVeKHsEA2AFGN9kNG7BWFXnnhesbsqpTPjZiGil7Q9 fnuXlHjEtLUqgQjmCFWoKlnxHxBSnh3ldq35tRWmSHcKzu67H2t71SXMTCCxRePeB3lVxc WHYUIFs8YE3yKTlvEB/zXozXi+jemaM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-224--qyvDma_NSGEkBU7W9JUHw-1; Wed, 22 Mar 2023 06:34:43 -0400 X-MC-Unique: -qyvDma_NSGEkBU7W9JUHw-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DA96080C8C1; Wed, 22 Mar 2023 10:34:42 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 814492027040; Wed, 22 Mar 2023 10:34:42 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 32MAYdDv3390084 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 22 Mar 2023 11:34:40 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 32MAYci93390083; Wed, 22 Mar 2023 11:34:38 +0100 Date: Wed, 22 Mar 2023 11:34:38 +0100 From: Jakub Jelinek To: Richard Biener Cc: Uros Bizjak , liuhongt , gcc-patches@gcc.gnu.org, crazylht@gmail.com, hjl.tools@gmail.com Subject: Re: [PATCH] Remove TARGET_GEN_MEMSET_SCRATCH_RTX since it's not used anymore. Message-ID: Reply-To: Jakub Jelinek References: <20230322025701.3369256-1-hongtao.liu@intel.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,BODY_8BITS,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Mar 22, 2023 at 11:18:33AM +0100, Richard Biener via Gcc-patches wrote: > Is/was the code ever exercised for non-x86? HJ, what was the reason to > abstract this? Initially the hook looked like rtx ix86_gen_scratch_sse_rtx (machine_mode mode) {   if (TARGET_SSE)     return gen_rtx_REG (mode, (TARGET_64BIT                               ? LAST_REX_SSE_REG                               : LAST_SSE_REG));   else     return gen_reg_rtx (mode); } on x86, but then PR104704 changed it to the same definition as the default hook. So I think it is fine to remove it. > OK if HJ thinks it was really unnecessary abstraction unlikely to be > required by another target. Jakub