From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id CA9833858CDA for ; Thu, 30 Mar 2023 16:06:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CA9833858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680192367; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=dZXlPZOiatvayiFvbgCQet3YcmkPzoWYjb7L+Dpdnxg=; b=YEkZB0N1aD5pGgsIJ8VpuuPraroZl4Jnc8hy++JKMHq+9zA1CSZk4j21wPSQGcFAkNHvBy wiyrZwTU4BhC5tr6dSPnaWBJ7IzZQNhHN5pHWtoSNbDp+UFb8zyec38sD0NoCrZDNnvGz4 Rqn5F09g/LrUwFr0HIM3VCIfI4MkprA= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-493-LnmEKn9DPl21XMF1YmBbcA-1; Thu, 30 Mar 2023 12:06:03 -0400 X-MC-Unique: LnmEKn9DPl21XMF1YmBbcA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7BF9C3C0F1A6; Thu, 30 Mar 2023 16:06:03 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2CE2A492B00; Thu, 30 Mar 2023 16:06:03 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 32UG60qe1771328 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 30 Mar 2023 18:06:01 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 32UG60xP1771327; Thu, 30 Mar 2023 18:06:00 +0200 Date: Thu, 30 Mar 2023 18:05:59 +0200 From: Jakub Jelinek To: Andrew MacLeod Cc: gcc-patches , Richard Biener , "hernandez, aldy" Subject: Re: recomputation and PR 109154 Message-ID: Reply-To: Jakub Jelinek References: <54bb3bc9-e0c1-b5ab-4447-5908b09fd19f@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Mar 30, 2023 at 11:58:19AM -0400, Andrew MacLeod wrote: > > On 3/30/23 09:41, Jakub Jelinek wrote: > > On Wed, Mar 29, 2023 at 01:22:27PM -0400, Andrew MacLeod wrote: > > > however, as seems to be the case often, better ranges result in, I now get: > > > > > > FAIL: 23_containers/vector/bool/allocator/copy.cc (test for excess errors) > > Our middle-end warnings are just badly designed :(, the better value ranges > > are, the more false positives they have. > > > > > commit 358d0ca44faf2e20fbacd0f74386308b5ca52cd4 > > > Author: Andrew MacLeod > > > Date: Tue Mar 28 12:16:34 2023 -0400 > > > > > > Add recursive GORI recompuations with a depth limit. > > LGTM for trunk, let's do with the regression incrementally. > > Or as Richard mentioned on IRC, one possibility would be to force this > > param temporarily to 1 (or whatever matches previous behavior) for the > > diagnostic range queries). > > > > You need a ChangeLog entry though... > > > Attached. I also removed the bogus warning in Walloc-13.c that no longer > happens > > So incrementally deal with it.. what? just let it fail? For today? Yes. Ok for trunk. > commit debb8ce1f9b9d5a72d88d0ae90a6b4da5130ff59 > Author: Andrew MacLeod > Date: Tue Mar 28 12:16:34 2023 -0400 > > Add recursive GORI recompuations with a depth limit. > > PR tree-optimization/109154 > gcc/ > * gimple-range-gori.cc (gori_compute::may_recompute_p): Add depth limit. > * gimple-range-gori.h (may_recompute_p): Add depth param. > * params.opt (ranger-recompute-depth): New param. > > gcc/testsuite/ > * gcc.dg/Walloca-13.c: Remove bogus warning that is now fixed. Jakub