From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4CC6B3858D28 for ; Fri, 31 Mar 2023 17:37:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CC6B3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680284250; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TsfpJaOHmvBEVRU/CLU2rJnA5T7t4FPQkblaZHDcEj4=; b=IKfqDhhgwjxj64uuzEcwASh7i1kdHPb2V30OxFsccmD4IfOBp+ZSEC2GU/R6e5A/S9TeYv DgT8BAGC6OXS3zfMtVhgr3UcLahBFJN0ggRhUp90yRF6QwlQkPzVH91AiakulMrC8gOBfG UOj9o80/Q3kYjQC0IYhCY8y1f5OUpmo= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-336-yZMzGon6NBKPI2VLVwKzCA-1; Fri, 31 Mar 2023 13:37:26 -0400 X-MC-Unique: yZMzGon6NBKPI2VLVwKzCA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4C0BD1C0950E; Fri, 31 Mar 2023 17:37:26 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D87E92166B33; Fri, 31 Mar 2023 17:37:25 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 32VHbNdt3978793 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 31 Mar 2023 19:37:23 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 32VHbMxX3978792; Fri, 31 Mar 2023 19:37:22 +0200 Date: Fri, 31 Mar 2023 19:37:21 +0200 From: Jakub Jelinek To: Andrew MacLeod Cc: Jeff Law , Hans-Peter Nilsson , gcc-patches@gcc.gnu.org, richard.guenther@gmail.com, aldyh@redhat.com Subject: Re: Regression with "recomputation and PR 109154" Message-ID: Reply-To: Jakub Jelinek References: <54bb3bc9-e0c1-b5ab-4447-5908b09fd19f@redhat.com> <20230331161207.DB49620444@pchp3.se.axis.com> <5c5825b2-c4f0-8aa7-c324-8256829e52f5@gmail.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Mar 31, 2023 at 01:02:18PM -0400, Andrew MacLeod wrote: > I guess it figures the recip is safe to put in, there will not be a divide > by zero. I think the problem was that 1/d was hoisted before the loop; as long as it is guarded with the d > 0.01 or e > 0.005 condition, it is fine. The test probably should have been a runtime test, doing the main stuff in some other noipa function and doing fetestexcept after it or something similar. > I guess the test is no longer testing what it should be? > > And yes, we could set he param back to 1 for the test... > add   --param=ranger-recompute-depth=1   makes the "issue" go away :-)  for > now. That looks reasonable unless we rewrite the test into runtime one (but we'd then need to double check that it was really miscompiled and would fail back then in 4.0). Jakub