From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) by sourceware.org (Postfix) with ESMTPS id 937AC3858D1E for ; Tue, 4 Apr 2023 10:14:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 937AC3858D1E Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=ucw.cz Authentication-Results: sourceware.org; spf=none smtp.mailfrom=kam.mff.cuni.cz Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 3C73728A575; Tue, 4 Apr 2023 12:14:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1680603298; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gGdmemiTcuJC8Y0FIeMyG5xFRn0v5Jy6XLKfrg6uYUA=; b=KjCJCFarI8OE/hdjzzN9qhyAx5YVh/vlWno6WGZJLquIOZQJtVjZHLrGkV0HsnLFJyfxRn jYN3wFGxfNDiey0W2V6y5bGySjim2GNaNwVuSXQt/YExynYIWmSCxrPqI9fYT2KNHMtDn+ mCEt5qLgu5VgWdzRSYaRRVMt8svRe0c= Date: Tue, 4 Apr 2023 12:14:58 +0200 From: Jan Hubicka To: Jakub Jelinek Cc: Richard Biener , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] tree-optimization/109304 - properly handle instrumented aliases Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > On Tue, Apr 04, 2023 at 01:21:40AM +0200, Jan Hubicka via Gcc-patches wrote: > > It is however really side case and I am worried about dropping > > pure/const from builtin declarations... > > Yeah, that can certainly break stuff. See e.g. the recently fixed > ICE when memcmp wasn't pure in PR109258. Yep, i think itis better to poke about this in stage1 (it is a can of worms). Clearly we have conflict here: if memcmp is implemented locally one can construct a testcase where profile would be rejected on -fprofile-use time if const flag is not cleared :(. But it should be rare thing happening in practice. Honza > > Jakub >