From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 06FC2385B508 for ; Tue, 18 Apr 2023 08:59:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 06FC2385B508 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681808398; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=QHnwD/Oc3PYjSk2yFzKv2+x99dVa8d8bVsDGG9gdtNE=; b=SbW1/bP5XRTOQCmT1/8SDTi1xCHzZRm9KO2jGo+62zaMPW1L5UWEsfCqzBkDj/BxWh3b3R QDn7t2Gx/d0m3Jb/Mw14CnGbdWeFKVea8QH00IW0chrq1LYNC9O38bf9TDUgRPHaoUMyE1 HZ95ixuCDdIeTvN2w1Y4d/t16jF4Ps8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-512-W7oBzRKTN0Cf2_cS60BJvQ-1; Tue, 18 Apr 2023 04:59:57 -0400 X-MC-Unique: W7oBzRKTN0Cf2_cS60BJvQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id EAEA2811E7C; Tue, 18 Apr 2023 08:59:56 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AC97040C6E6F; Tue, 18 Apr 2023 08:59:56 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 33I8xs1k108220 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 18 Apr 2023 10:59:54 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 33I8xrYP108219; Tue, 18 Apr 2023 10:59:53 +0200 Date: Tue, 18 Apr 2023 10:59:53 +0200 From: Jakub Jelinek To: Jonathan Wakely Cc: Jonathan Wakely , Patrick Palka , gcc-patches , libstdc++ Subject: Re: [PATCH 2/2] libstdc++: Implement range_adaptor_closure from P2387R3 [PR108827] Message-ID: Reply-To: Jakub Jelinek References: <20230414194512.2569383-1-ppalka@redhat.com> <20230414194512.2569383-2-ppalka@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Apr 18, 2023 at 09:57:19AM +0100, Jonathan Wakely wrote: > On Mon, 17 Apr 2023 at 08:26, Jonathan Wakely via Libstdc++ > wrote: > > > > On Mon, 17 Apr 2023, 05:28 Patrick Palka via Libstdc++, < > > libstdc++@gcc.gnu.org> wrote: > > > > > On Fri, 14 Apr 2023, Patrick Palka wrote: > > > > > > > Tested on x86_64-pc-linux-gnu, does this look OK for trunk? > > > > > > > > PR libstdc++/108827 > > > > > > > > libstdc++-v3/ChangeLog: > > > > > > > > * include/bits/ranges_cmp.h (__cpp_lib_ranges): Bump value > > > > for C++23. > > > > * include/std/ranges (range_adaptor_closure): Define for C++23. > > > > * include/std/version (__cpp_lib_ranges): Bump value for > > > > C++23. > > > > * testsuite/std/ranges/version_c++23.cc: Bump expected value > > > > of __cpp_lib_ranges. > > > > * testsuite/std/ranges/range_adaptor_closure.cc: New test. > > > > > > Here's a standalone version of this patch (not dependent on the first > > > patch in the series) it terms of the current non-CRTP representation > > > of _RangeAdaptorClosure: > > > > > > > OK, thanks for separating this from the other change. > > I'd like RM approval to push this C++23-only change to gcc-13 as well as trunk. Ok. Jakub