From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9B5953858C52 for ; Mon, 10 Apr 2023 07:11:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9B5953858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681110694; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=51kklWaGGJnN+N8MK1N9BBFDt0kWZzo4FIbhxwC4V1o=; b=F5PYD2rNYLarDIYKMOH+DSosGBRWwLagutePH7kPtl/4s/JJeMrStQATN7ckR8D87mFwne M5gYuJtAdNPX9XoQXcg2OhO64koH2xyCOUYqkgfwtFoUjULmxd/RgpsZRp416UmelKH1oJ Yn2GRTi8TYNyi3oo4IJABOhUh3szlKE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-575-tBhdlhzLPRGKF-uSze4uHw-1; Mon, 10 Apr 2023 03:11:30 -0400 X-MC-Unique: tBhdlhzLPRGKF-uSze4uHw-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 565758996E7; Mon, 10 Apr 2023 07:11:30 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 05256492B00; Mon, 10 Apr 2023 07:11:29 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 33A7B1dw2312764 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 10 Apr 2023 09:11:01 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 33A7AxVd2312763; Mon, 10 Apr 2023 09:10:59 +0200 Date: Mon, 10 Apr 2023 09:10:59 +0200 From: Jakub Jelinek To: Jeff Law Cc: Eric Botcazou , gcc-patches@gcc.gnu.org, Richard Biener , Richard Sandiford Subject: Re: [PATCH] combine: Fix simplify_comparison AND handling for WORD_REGISTER_OPERATIONS targets [PR109040] Message-ID: Reply-To: Jakub Jelinek References: <2220543.iZASKD2KPV@fomalhaut> <3412470.QJadu78ljV@fomalhaut> <8d3c3861-c291-e762-a2a8-0b520f39a7e3@gmail.com> MIME-Version: 1.0 In-Reply-To: <8d3c3861-c291-e762-a2a8-0b520f39a7e3@gmail.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sat, Apr 08, 2023 at 06:25:32PM -0600, Jeff Law wrote: > > > On 4/6/23 08:21, Eric Botcazou wrote: > > > > So, perhaps just in the return op0; case add further code for > > > WORD_REGISTER_OPERATIONS and sub-word modes which will call nonzero_bits > > > again for the word mode and decide if it is still safe. > > > > Does it work to just replace mode by word_mode in the calls to nonzero_bits? > It helps marginally -- basically we defer mucking up the code a bit. We > then hit this in simplify_and_const_int_1: > > > /* See what bits may be nonzero in VAROP. Unlike the general case of > a call to nonzero_bits, here we don't care about bits outside > MODE. */ > > nonzero = nonzero_bits (varop, mode) & GET_MODE_MASK (mode); > > That just seems wrong for WORD_REGISTER_OPERATIONS targets. > > > Hacking both locations in a similar manner fixes the test. If so, can you post that in patch form and can we go with that version plus the testcase (e.g. from the first patch I've posted where I've changed dse)? Jakub