From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3B13E3857019 for ; Fri, 14 Apr 2023 09:50:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3B13E3857019 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681465832; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=tECx4mfAPHxO49asSIpcFWobzOX9+115+dw569Vz10g=; b=goC+mYBQtegkG9koh5KZsLASXFK0QxnjcsKNYeB1XyW8nMX0Sk0lhxeNSfj3bID57QUDer wuumxl7eaPOqFFitZMQnz8PQtsfnFrqIhpOOMkARBtKhUA4GHNg1nvF9XmzbaqjDQBo14d 3fpWDH4b7J0oDVeYdQV6lLkZVxY0/3Y= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-190-nMbY4YoeMhmUq2aUQm5qcA-1; Fri, 14 Apr 2023 05:50:31 -0400 X-MC-Unique: nMbY4YoeMhmUq2aUQm5qcA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8F9041C07566; Fri, 14 Apr 2023 09:50:31 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 519AF2027043; Fri, 14 Apr 2023 09:50:31 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 33E9oSYC1925326 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 14 Apr 2023 11:50:29 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 33E9oRR41925324; Fri, 14 Apr 2023 11:50:27 +0200 Date: Fri, 14 Apr 2023 11:50:27 +0200 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix vect-simd-clone testcase dump scanning Message-ID: Reply-To: Jakub Jelinek References: <20230414094255.F02F313498@imap2.suse-dmz.suse.de> MIME-Version: 1.0 In-Reply-To: <20230414094255.F02F313498@imap2.suse-dmz.suse.de> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Apr 14, 2023 at 11:42:55AM +0200, Richard Biener via Gcc-patches wrote: > This replaces i686*-*-* && { ! lp64 } with the appropriate > { i?86-*-* x86_64-*-* } && { ! lp64 } for the testcases and > also amends the e variants checking last variant for avx. > I've used avx in the dump scanning, not avx_runtime, since > the dumps get produced when one would not execute but only > compile them. The f varaints lack AVX checking, I didn't avx_runtime was actually intentional. The thing is that the testcase has /* { dg-additional-options "-mavx" { target avx_runtime } } */ So, if avx_runtime, we know we are compiled with -mavx. If not, we don't really know, it could be with -mavx because user configured gcc to default to -mavx through some --with-arch=, or because it was tested with --target_board=unix/-mavx etc. If we wanted to make sure it is exact, we could do /* { dg-additional-options "-mno-avx" { target i?86-*-* x86_64-*-* } } */ /* { dg-additional-options "-mavx" { target avx_runtime } } */ and then avx_runtime can be actually trusted. Jakub