From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0089E3858D20 for ; Fri, 21 Apr 2023 20:45:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0089E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682109939; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=HEAn+eiHP+07xs6VligbKctXRxYevUKXg9HmOveGzSY=; b=DqRS+vvNenlbgqPqsgv+R4Umuy2E080vPilk/1X0QwvnPS+ZxFPjhjYK4N3RRAjGnypV5h ysPwsTb9yObWBnp2BokYPKQ+Cd6Z2LBOxx1W5tycyvLVg+baltvDnqwD43Bz01+HquOuhd 7k6HRBQOgzVzTgXi9PcoyZlIt/oHwog= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-306-YJpkX__-NyaWnZzCEp53rw-1; Fri, 21 Apr 2023 16:45:36 -0400 X-MC-Unique: YJpkX__-NyaWnZzCEp53rw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B1CE7800047; Fri, 21 Apr 2023 20:45:35 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B2B5C16024; Fri, 21 Apr 2023 20:45:35 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 33LKjWgU009802 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 21 Apr 2023 22:45:32 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 33LKjVE8009801; Fri, 21 Apr 2023 22:45:31 +0200 Date: Fri, 21 Apr 2023 22:45:30 +0200 From: Jakub Jelinek To: Mikael Morin Cc: Aldy Hernandez , "Joseph S. Myers" , GCC patches , Andrew MacLeod Subject: Re: [PATCH] Implement range-op entry for sin/cos. Message-ID: Reply-To: Jakub Jelinek References: <20230418131250.310916-1-aldyh@redhat.com> <4772e205-2123-1fa6-1cd6-8bd6ee22b439@orange.fr> MIME-Version: 1.0 In-Reply-To: <4772e205-2123-1fa6-1cd6-8bd6ee22b439@orange.fr> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Apr 21, 2023 at 10:43:44PM +0200, Mikael Morin wrote: > Hello, > > > --- gcc/gimple-range-op.cc.jj 2023-04-21 17:09:48.250367999 +0200 > > +++ gcc/gimple-range-op.cc 2023-04-21 18:37:26.048325391 +0200 > > @@ -439,20 +436,38 @@ public: > > r.set_varying (type); > > return true; > > } > > + > > // Results outside of [-1.0, +1.0] are impossible. > > REAL_VALUE_TYPE lb = lhs.lower_bound (); > > REAL_VALUE_TYPE ub = lhs.upper_bound (); > > - if (real_less (&lb, &dconstm1) > > - || real_less (&dconst1, &ub)) > > + if (real_less (&lb, &dconstm1) || real_less (&dconst1, &ub)) > > { > > Shouldn't lb and ub be swapped in this condition? Yes, they should. > If I understand correctly, we are looking for ranges like [whatever,x] where > x < -1.0 or [y, whatever] where 1.0 < y. Jakub