From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x633.google.com (mail-pl1-x633.google.com [IPv6:2607:f8b0:4864:20::633]) by sourceware.org (Postfix) with ESMTPS id 9F6DF3858C50 for ; Sat, 22 Apr 2023 06:25:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9F6DF3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x633.google.com with SMTP id d9443c01a7336-1a66b9bd7dfso31903105ad.2 for ; Fri, 21 Apr 2023 23:25:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1682144726; x=1684736726; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=/HCLF+ff3ikZqifo/nez0sQK2hSg5dA7TvBwRnyfukQ=; b=ehOMxuP0tIpbnDJOOA14yKqrfF5xKMhAfXYzBDSAHK0jAQZ9vEbaNECw+OelqaLvHN nphvS4NEDn+y5SODi+lqKe4WAoEE+2iQUbSkLJCo6IUm7wnwsfFEdeJPkzMfKrF2sKVV SS6WvUKW/+/9QymJJMxONoWBzsTPEjFvUJfU7ZLi5CoqIxbh3JzHkpfhDI2ahEuZ09zW gpp5qTkJau1iRHk7OIMPRZlFzdsQcnENSTLhwZKAHMhKQetPnliGgOchbx/fK4CHXc10 AXhh/WRf5VFMGNNpfYLv7r9x85KYkKYzRmeBJYiyR8xIl3hrlrFh7fnoBg3KNc1SgKgF r/Zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682144726; x=1684736726; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/HCLF+ff3ikZqifo/nez0sQK2hSg5dA7TvBwRnyfukQ=; b=IDq2THZNWp5W8RuxCnuNrA3JzEhSQK2GvHfazLfciQ+L79AXq3Jj8hp5TqmOJE3LKk U6/5Ayh8HXkPmbBkiRjyy6FdLHYpOngJKjz3iobnNW+gGMR0Jo1kvuKx/SNKc3+E//Cv npTgwMYHHPNpmsC4GzONARfQs5UHd4USws3HWXCsQKZl/vTWYrBoBw/JAi/aynoYCr5J zawggj/ZHj0Kfib6H2vasYytT4O5nKQpZNo+rISfQ+XsiO1mlXfTrddg28AmG/JjyOm2 yTvXkwK4gTERwpa3LNjbjxdBTTbSAv9Aw/LpY52Qnvda+zbZ0mXOKKa1y1YZ1LrkHdaC Drbw== X-Gm-Message-State: AAQBX9f0nmBQbQ7m4H6Z0rt0+RLrvaxuO5uEvteWcEKcOFMt6OhruOQu UERLP18W7uVtNC1xWN2nNMpXLqWyDjk= X-Google-Smtp-Source: AKy350YfiwxCS/pOeBXgAHipFree6dUVquoA7jhjC/iN3mBFcb1DplLM/1V/m4h/Ayqrofq/LLp/vw== X-Received: by 2002:a17:903:113:b0:1a5:167f:620f with SMTP id y19-20020a170903011300b001a5167f620fmr6344214plc.15.1682144726137; Fri, 21 Apr 2023 23:25:26 -0700 (PDT) Received: from Thaum.localdomain (125-209-144-50.tpgi.com.au. [125.209.144.50]) by smtp.gmail.com with ESMTPSA id md17-20020a17090b23d100b0024744818bc5sm5365383pjb.9.2023.04.21.23.25.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 23:25:25 -0700 (PDT) Date: Sat, 22 Apr 2023 16:25:13 +1000 From: Nathaniel Shead To: gcc-patches@gcc.gnu.org Cc: Nathaniel Shead Subject: [PATCH] c++: Fix ICE with parameter pack of decltype(auto) [PR103497] Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Bootstrapped and tested on x86_64-pc-linux-gnu. -- 8< -- This patch raises an error early when the decltype(auto) specifier is used as a parameter of a function. This prevents any issues with an unexpected tree type later on when performing the call. PR 103497 gcc/cp/ChangeLog: * parser.cc (cp_parser_simple_type_specifier): Add check for decltype(auto) as function parameter. gcc/testsuite/ChangeLog: * g++.dg/pr103497.C: New test. Signed-off-by: Nathaniel Shead --- gcc/cp/parser.cc | 10 ++++++++++ gcc/testsuite/g++.dg/pr103497.C | 7 +++++++ 2 files changed, 17 insertions(+) create mode 100644 gcc/testsuite/g++.dg/pr103497.C diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc index e5f032f2330..1415e07e152 100644 --- a/gcc/cp/parser.cc +++ b/gcc/cp/parser.cc @@ -19884,6 +19884,16 @@ cp_parser_simple_type_specifier (cp_parser* parser, && cp_lexer_peek_nth_token (parser->lexer, 2)->type != CPP_SCOPE) { type = saved_checks_value (token->u.tree_check_value); + /* Within a function parameter declaration, decltype(auto) is always an + error. */ + if (parser->auto_is_implicit_function_template_parm_p + && TREE_CODE (type) == TEMPLATE_TYPE_PARM + && AUTO_IS_DECLTYPE (type)) + { + error_at (token->location, + "cannot declare a parameter with %"); + type = error_mark_node; + } if (decl_specs) { cp_parser_set_decl_spec_type (decl_specs, type, diff --git a/gcc/testsuite/g++.dg/pr103497.C b/gcc/testsuite/g++.dg/pr103497.C new file mode 100644 index 00000000000..bcd421c2907 --- /dev/null +++ b/gcc/testsuite/g++.dg/pr103497.C @@ -0,0 +1,7 @@ +// { dg-do compile { target c++14 } } + +void foo(decltype(auto)... args); // { dg-error "parameter with .decltype.auto..|no parameter packs" } + +int main() { + foo(); +} -- 2.34.1