From: Jan Hubicka <hubicka@ucw.cz>
To: Richard Biener <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] rtl-optimization/109585 - alias analysis typo
Date: Tue, 25 Apr 2023 11:52:42 +0200 [thread overview]
Message-ID: <ZEei6mwjCPdmS+eA@kam.mff.cuni.cz> (raw)
In-Reply-To: <20230425062543.851AF13466@imap2.suse-dmz.suse.de>
> When r10-514-gc6b84edb6110dd2b4fb improved access path analysis
> it introduced a typo that triggers when there's an access to a
> trailing array in the first access path leading to false
> disambiguation.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu.
>
> Honza, does this look OK?
Yes, sorry for that - that is a nasty pasto :(
Honza
>
> Thanks,
> Richard.
>
> PR rtl-optimization/109585
> * tree-ssa-alias.cc (aliasing_component_refs_p): Fix typo.
>
> * gcc.dg/torture/pr109585.c: New testcase.
> ---
> gcc/testsuite/gcc.dg/torture/pr109585.c | 33 +++++++++++++++++++++++++
> gcc/tree-ssa-alias.cc | 2 +-
> 2 files changed, 34 insertions(+), 1 deletion(-)
> create mode 100644 gcc/testsuite/gcc.dg/torture/pr109585.c
>
> diff --git a/gcc/testsuite/gcc.dg/torture/pr109585.c b/gcc/testsuite/gcc.dg/torture/pr109585.c
> new file mode 100644
> index 00000000000..f92de7c1f2e
> --- /dev/null
> +++ b/gcc/testsuite/gcc.dg/torture/pr109585.c
> @@ -0,0 +1,33 @@
> +/* { dg-do run } */
> +
> +#include <stdlib.h>
> +
> +struct P {
> + long v;
> + struct P *n;
> +};
> +
> +struct F {
> + long x;
> + struct P fam[];
> +};
> +
> +int __attribute__((noipa))
> +f(struct F *f, int i)
> +{
> + struct P *p = f->fam;
> + asm("" : "+r"(f): "r"(p));
> + p->v = 0;
> + p->n = 0;
> + return f->fam->n != 0;
> +}
> +
> +int
> +main()
> +{
> + struct F *m = malloc (sizeof (long) + 2 * sizeof (struct P));
> + m->fam[0].n = &m->fam[1];
> + if (f (m, 0))
> + abort ();
> + return 0;
> +}
> diff --git a/gcc/tree-ssa-alias.cc b/gcc/tree-ssa-alias.cc
> index 81bc51ed4ad..8a1ec9091fa 100644
> --- a/gcc/tree-ssa-alias.cc
> +++ b/gcc/tree-ssa-alias.cc
> @@ -1330,7 +1330,7 @@ aliasing_component_refs_p (tree ref1,
> /* If we didn't find a common base, try the other way around. */
> if (cmp_outer <= 0
> || (end_struct_ref1
> - && compare_type_sizes (TREE_TYPE (end_struct_ref1), type1) <= 0))
> + && compare_type_sizes (TREE_TYPE (end_struct_ref1), type2) <= 0))
> {
> int res = aliasing_component_refs_walk (ref2, type2, base2,
> offset2, max_size2,
> --
> 2.35.3
prev parent reply other threads:[~2023-04-25 9:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 6:25 Richard Biener
2023-04-25 9:52 ` Jan Hubicka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZEei6mwjCPdmS+eA@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).