From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id AE11A3858D37 for ; Thu, 27 Apr 2023 12:12:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AE11A3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682597522; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Y29QpfcwHQS3OACUSFGeb+xGX79SaTnnpTfivd/sbQU=; b=EMWD0zgIE5SDlcflkqPwp+8+f1FIoGLVyQfzS3kmu0zRXhsOMMUcWqLhVc1Tp3/Bx99Ytn 9y2K/BxCFo1c1anexlIls3Fc3Z6AXunk+MahMHG3LytSWzhpsbA+NNKc2qWX6Hi7HKCYfj g8ygtoHtj79P2+zgWoSMtAdveegZfp8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-568-bWnM_BMrNe2uQm0fnf8AMw-1; Thu, 27 Apr 2023 08:11:58 -0400 X-MC-Unique: bWnM_BMrNe2uQm0fnf8AMw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DA6D2A0F396; Thu, 27 Apr 2023 12:11:55 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9D70C40C2064; Thu, 27 Apr 2023 12:11:55 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 33RCBqwX2757783 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 27 Apr 2023 14:11:53 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 33RCBqrM2757782; Thu, 27 Apr 2023 14:11:52 +0200 Date: Thu, 27 Apr 2023 14:11:51 +0200 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] tree-optimization/109170 - bogus use-after-free with __builtin_expect Message-ID: Reply-To: Jakub Jelinek References: <34641.123042708104200740@us-mta-611.us.mimecast.lan> MIME-Version: 1.0 In-Reply-To: <34641.123042708104200740@us-mta-611.us.mimecast.lan> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Apr 27, 2023 at 12:10:40PM +0000, Richard Biener wrote: > The following generalizes the range-op for __builtin_expect > by using the fnspec machinery. > > We've defered this to stage1 - bootstrapped and tested on > x86_64-unknown-linux-gnu. > > OK? > > Thanks, > Richard. > > PR tree-optimization/109170 > * gimple-range-op.cc (gimple_range_op_handler::maybe_builtin_call): > Handle __builtin_expect and similar via cfn_pass_through_arg1 > and inspecting the calls fnspec. > * builtins.cc (builtin_fnspec): Handle BUILT_IN_EXPECT > and BUILT_IN_EXPECT_WITH_PROBABILITY. Ok, thanks. Jakub