From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D123D3858C78 for ; Fri, 28 Apr 2023 11:39:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D123D3858C78 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682681983; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=wiLW+p1pCsVpOWMowGyDmz5RhFHGGoKAEXrFJqSB03Q=; b=AY0o/F99/XlZDwOuZwcLyXS0JzoGXP8Ll5mLg1Z6JN7sResnnRBlq5r1B+KItpNsXddXpd +ZNEFzIT7KOrTbedgyHkVdmDmWETWLL91VirXZFni8BSOW00RU6/3q7DwBc90QX/KbBifw mtqhDFE6kHM6gQAcL5WK9XTAUHcaTW0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-211-vFbvKpbEPeaW8B0OsI5Y9A-1; Fri, 28 Apr 2023 07:39:40 -0400 X-MC-Unique: vFbvKpbEPeaW8B0OsI5Y9A-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CB08CA0F385; Fri, 28 Apr 2023 11:39:39 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 67EAB1121314; Fri, 28 Apr 2023 11:39:39 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 33SBdZSe854428 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 28 Apr 2023 13:39:36 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 33SBdYnV854427; Fri, 28 Apr 2023 13:39:34 +0200 Date: Fri, 28 Apr 2023 13:39:33 +0200 From: Jakub Jelinek To: Jakub Jelinek via Gcc-patches , Richard Biener , Aldy Hernandez , "Joseph S. Myers" , Siddhesh Poyarekar , Andrew MacLeod , richard.sandiford@arm.com Subject: Re: [PATCH] v2: Add targetm.libm_function_max_error Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_MANYTO,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Apr 28, 2023 at 12:29:58PM +0100, Richard Sandiford wrote: > Jakub Jelinek via Gcc-patches writes: > > Hi! > > > > On Thu, Apr 27, 2023 at 10:34:59AM +0000, Richard Biener wrote: > >> OK. As said the patch itself looks good to me, let's go ahead. We > >> have plenty of time to backtrack until GCC 14. > > > > Thanks. Unfortunately when I started using it, I've discovered that the > > CASE_CFN_xxx_ALL macros don't include the CFN_xxx cases, just > > CFN_BUILT_IN_xxx* cases. > > > > So here is an updated version of the patch I'll bootstrap/regtest tonight > > which instead uses CASE_CFN_xxx: CASE_CFN_xxx_FN: > > Shouldn't we change something in that case? The point of these macros > is to wrap things up a single easy-to-use name, so something feels wrong > if we're having to use a repeated pattern like this. Maybe. But unfortunately not all builtins have those CFN_xxx enumerators, some have just CFN_BUILT_IN_xxx{,L,F}, otherwise have CFN_BUILT_IN_xxx{,L,F,F16,F32,F64,F128} and others have that plus CFN_xxx. So we'd perhaps need some other macros for the all but CFN_xxx and perhaps use ALL only for the cases where it is really all of them. Jakub