From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 93D3C3858D35 for ; Mon, 8 May 2023 15:18:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 93D3C3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683559115; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Ycf6GbFsPWz6K9RT1QQH5kvn4JCM97ttIwc8N3IDjPs=; b=KjwFAC9Uy67MeToqoRQGzZwP9PQtiFVvIQOnvJf7LgwgoxqV8JkWwdKjkbog94W59fBrDt p66gkXASSXXj4JNe3xZ7/2J//A1SZZ1bST08uBJIBbldyZILp2+g57tvAZtLkvphBrC2WU MUTL4c1wQNXfY1gDlAMEJcg/yRQEtoY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-93-RLJ2Kg0INdWL98En9KB-Hg-1; Mon, 08 May 2023 11:18:32 -0400 X-MC-Unique: RLJ2Kg0INdWL98En9KB-Hg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6F12C88B780; Mon, 8 May 2023 15:18:15 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.156]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1B2C840C2063; Mon, 8 May 2023 15:18:14 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 348FI9RZ3588447 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 8 May 2023 17:18:09 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 348FI7C03588446; Mon, 8 May 2023 17:18:07 +0200 Date: Mon, 8 May 2023 17:18:07 +0200 From: Jakub Jelinek To: Richard Biener Cc: Jason Merrill , "Joseph S. Myers" , Eric Botcazou , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] tree: Fix up save_expr [PR52339] Message-ID: Reply-To: Jakub Jelinek References: <4070a6dd-0e14-1cdd-dc59-62578fea965e@redhat.com> <426ae86b-d713-9353-21e4-c707e26832d5@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, May 08, 2023 at 06:23:54AM +0000, Richard Biener wrote: > I wonder if we should defer some of the choices to a langhook > like make the tree_invariant_p_1 a langhook invocation with the > default to call tree_invariant_p_1. After lowering we can reset > the langhook to the default. We certainly can. The only outliner would be Ada I think, but we really need to know what holds and doesn't hold there. Jakub