From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 5FE1E3858C5F for ; Thu, 18 May 2023 12:59:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5FE1E3858C5F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684414790; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=lYWbAVXqzMBNN/GTKRSmV5ZIL6ErpH01rdeoBF4M0fI=; b=g7sIo6vUHA8QWkp0MAaETujZv9vfqnri9uz+Zr3w1YSHfz5/AvfBeWoFbwyaWLNbYH9WDt XJJcwHyWNwKyQXSl3o+sFNfauZXOnfneZ5yZYDQjggQ6G3YkIICI8agdWi8fkC8gtqlD2I sxbELxsNc1hWHhS1g/0tId5lewg5Eac= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-638--2-L5UxsP0Gpdd3srbSuzQ-1; Thu, 18 May 2023 08:59:48 -0400 X-MC-Unique: -2-L5UxsP0Gpdd3srbSuzQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9A8CF867946 for ; Thu, 18 May 2023 12:59:48 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5B1D240C206F; Thu, 18 May 2023 12:59:48 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 34ICxjwk674008 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 18 May 2023 14:59:46 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 34ICxj3Y674007; Thu, 18 May 2023 14:59:45 +0200 Date: Thu, 18 May 2023 14:59:45 +0200 From: Jakub Jelinek To: Jonathan Wakely Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 2/3] gcc: Fix nonportable shell syntax in "test" and "[" commands [PR105831] Message-ID: Reply-To: Jakub Jelinek References: <20230518125647.2105203-1-jwakely@redhat.com> <20230518125647.2105203-3-jwakely@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230518125647.2105203-3-jwakely@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, May 18, 2023 at 01:56:46PM +0100, Jonathan Wakely via Gcc-patches wrote: > --- a/gcc/testsuite/gcc.test-framework/gen_directive_tests > +++ b/gcc/testsuite/gcc.test-framework/gen_directive_tests > @@ -322,8 +322,8 @@ two() { > echo "${GOOD_PROG}" >> $FILE1 > echo "${GOOD_PROG}" > $FILE2 > > - if [ "${FAIL_VERSION}" == "yes" ]; then > - if [ "${EXP}" == "${EXP_PASS}" ]; then > + if "yes" ]; then This line looks suspicious... > + if [ "${EXP}" = "${EXP_PASS}" ]; then > NAME=${KIND1}-${KIND2}-${EXP_FAIL} > else > NAME=${KIND1}-${KIND2}-${EXP_XFAIL} > @@ -364,8 +364,8 @@ three() { > echo "${GOOD_PROG}" >> $FILE1 > echo "${GOOD_PROG}" > $FILE2 > > - if [ "${FAIL_VERSION}" == "${yes}" ]; then > - if [ "${EXP}" == "${EXP_PASS}" ]; then > + if [ "${FAIL_VERSION}" = "${yes}" ]; then > + if [ "${EXP}" = "${EXP_PASS}" ]; then > NAME=${KIND1}-${KIND2}-${KIND3}-${EXP_FAIL} > else > NAME=${KIND1}-${KIND2}-${KIND3}-${EXP_XFAIL} > -- > 2.40.1 Jakub