From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 934043858CDB for ; Thu, 18 May 2023 13:15:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 934043858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684415732; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=XHEf78ps93DakjnHeEvpqVRMjZTXd+HpDXLitIOgULY=; b=BbMt1t3FIZWOCfmj5BcaQhi8SXEc/SIw6WufdXwYV0f7yCEphpuGAaNMfG3KA1oyBWQL37 /beKB4uRF/YA8fKLWbC9vcy2eECkVeyK2shDslmzC2TMERxSg/ltk8vbgp5211IatC5BYz oJmlXVWOyOHRHowmr0uU+L+fcf2BHPo= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-117-gNdGtudFOBO_UP1ij7jmgw-1; Thu, 18 May 2023 09:15:31 -0400 X-MC-Unique: gNdGtudFOBO_UP1ij7jmgw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B0E5C28135A9 for ; Thu, 18 May 2023 13:15:30 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7233440C6EC4; Thu, 18 May 2023 13:15:30 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 34IDFSOn674736 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 18 May 2023 15:15:28 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 34IDFRhm674735; Thu, 18 May 2023 15:15:27 +0200 Date: Thu, 18 May 2023 15:15:27 +0200 From: Jakub Jelinek To: Jonathan Wakely Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH v2 2/3] gcc: Fix nonportable shell syntax in "test" and "[" commands [PR105831] Message-ID: Reply-To: Jakub Jelinek References: <20230518125647.2105203-3-jwakely@redhat.com> <20230518130358.2106172-1-jwakely@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230518130358.2106172-1-jwakely@redhat.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, May 18, 2023 at 02:03:58PM +0100, Jonathan Wakely via Gcc-patches wrote: > Fixes a fat finger error in the v1 patch, spotted by Jakub. > > -- >8 -- > > POSIX sh does not support the == for string comparisons, use = instead. > > The gen_directive_tests script uses a bash shebang so == does work, but > there's no reason this script can't just use the more portable form > anyway. > > PR bootstrap/105831 > > gcc/ChangeLog: > > * config.gcc: Use = operator instead of ==. > > gcc/testsuite/ChangeLog: > > * gcc.test-framework/gen_directive_tests: Use = operator instead > of ==. That looks better ;) Ok. Jakub