From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2058.outbound.protection.outlook.com [40.107.6.58]) by sourceware.org (Postfix) with ESMTPS id C6BED3858D32 for ; Fri, 2 Jun 2023 16:07:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C6BED3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cnrBgnyebiu0au5/nftrcp4rnXDR86cmzWVYhY8PrDA=; b=UBizQSP/66S2+F+L54Ttoi5NObxVVf4MvhqJ8jD1lM6LCdXbl/j9OZjfw/OEMr3Y5PpIh907Jg9hCOWNJEWJ1pLiGTG5IeCF5tNJgOW+Sd/Rk/XJ0Iea8Whin8VhNPPg17fPKtK3n1z+vgA62jbPZaJYYFsrjxoO3LKRNzkG1kc= Received: from DUZPR01CA0022.eurprd01.prod.exchangelabs.com (2603:10a6:10:46b::12) by AS8PR08MB6664.eurprd08.prod.outlook.com (2603:10a6:20b:351::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.24; Fri, 2 Jun 2023 16:07:55 +0000 Received: from DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:46b:cafe::70) by DUZPR01CA0022.outlook.office365.com (2603:10a6:10:46b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.22 via Frontend Transport; Fri, 2 Jun 2023 16:07:55 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT062.mail.protection.outlook.com (100.127.142.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.24 via Frontend Transport; Fri, 2 Jun 2023 16:07:55 +0000 Received: ("Tessian outbound 5154e9d36775:v136"); Fri, 02 Jun 2023 16:07:55 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 5b576e2154b65e87 X-CR-MTA-TID: 64aa7808 Received: from b9fcbe65f4de.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 5EF941B6-68CA-4523-AC39-2FD55786509A.1; Fri, 02 Jun 2023 16:07:49 +0000 Received: from EUR05-DB8-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b9fcbe65f4de.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Fri, 02 Jun 2023 16:07:49 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UVxgMhtWA4VjlcYwky3tEVkf3k0UdPpZmx0S4GbndMNDO5Ssb6W5byN7tTnuBAkKPGc8qPrzgCdEdsJ/5RyLwv2qMF3QXaxqtKhMKL54ui8m6moH2j/tiYhPYHIq/Rh12//Y5t80Ftf/tnPi/lLm2Q4ZBYKNsKKxZM2xMGIvSOGuEx8+Qo59ijz4MYwIFGZMEfetkzKPfOSbXwo4kpygOCwFs3EDR9UuunM1EyPF5bQ1NdRTI9caCn337fHa563NAO9cVqAWvTsoN8vkdlsX8qrF58IrzcHvV8bu6NP9VQik6oRhwj2LK0iuRxtplRi5ewpoj/ePEKl8m/sYyoM2Ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cnrBgnyebiu0au5/nftrcp4rnXDR86cmzWVYhY8PrDA=; b=BnATAj60T1ilUPQqpcl623XHQBFAzxp52p/iob0TfEntiBr/LCyJ2CxCSj2NDn/YRROEE53c6t+xgcqbKSevwOjEQ6FAIDuoMOI+pTRlpXJoHk9+2WFkUBW7Vqgm3X33lelXJXUClHWJCvNQ+I0qE3O1nJWi3ZCRLhdIr7Odqc1SOkm27onV7ZhvtleCqaFm6SIpYNEEvf8p+F0m1KVuq4dUWJzyeikGmF6a4F0bozbYFpEO5lOSeUN26iX0D5Jklgm9dSXAcuQUleVqbtxo/Ourf27A2krpgvWA/LPl+sKJNM5PfeRsiCwHzHz7+6OV38RqqsYyIdjtM54J+1MFnQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cnrBgnyebiu0au5/nftrcp4rnXDR86cmzWVYhY8PrDA=; b=UBizQSP/66S2+F+L54Ttoi5NObxVVf4MvhqJ8jD1lM6LCdXbl/j9OZjfw/OEMr3Y5PpIh907Jg9hCOWNJEWJ1pLiGTG5IeCF5tNJgOW+Sd/Rk/XJ0Iea8Whin8VhNPPg17fPKtK3n1z+vgA62jbPZaJYYFsrjxoO3LKRNzkG1kc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from PAXPR08MB7201.eurprd08.prod.outlook.com (2603:10a6:102:20b::17) by AM8PR08MB6516.eurprd08.prod.outlook.com (2603:10a6:20b:363::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.24; Fri, 2 Jun 2023 16:07:47 +0000 Received: from PAXPR08MB7201.eurprd08.prod.outlook.com ([fe80::5b72:ef2:156a:296a]) by PAXPR08MB7201.eurprd08.prod.outlook.com ([fe80::5b72:ef2:156a:296a%6]) with mapi id 15.20.6455.024; Fri, 2 Jun 2023 16:07:47 +0000 Date: Fri, 2 Jun 2023 17:07:42 +0100 From: Alex Coplan To: Iain Sandoe Cc: David Faust , GCC Patches Subject: Re: [PATCH 2/2] btf: improve -dA comments for testsuite Message-ID: References: <20230525163740.6062-1-david.faust@oracle.com> <20230530182702.8020-1-david.faust@oracle.com> <20230530182702.8020-2-david.faust@oracle.com> <16c13d09-eff0-8722-52c1-fe2eec165f11@oracle.com> <930CE61F-7427-46EE-A7C7-F13D0C584E9B@sandoe.co.uk> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <930CE61F-7427-46EE-A7C7-F13D0C584E9B@sandoe.co.uk> X-ClientProxiedBy: LO4P123CA0605.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:314::7) To PAXPR08MB7201.eurprd08.prod.outlook.com (2603:10a6:102:20b::17) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: PAXPR08MB7201:EE_|AM8PR08MB6516:EE_|DBAEUR03FT062:EE_|AS8PR08MB6664:EE_ X-MS-Office365-Filtering-Correlation-Id: 3f8b6ea0-cb5a-4d65-3977-08db638386b8 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: cttznHGMV7UhKdExfKU65fxHoi/um6K7I6Lqw2aJBOxV70CD720whNw+l12EmE24XG2Q+wazn39vzKCJWKSj/kbDId4f1o/zjYuLqUM0dPsZVztUpgEY55Zq5C++K8fI+tp8KcFUW06GB8ZMVTGKPj84izsZq5k7qTSNG+d1NpoZx47ZvvAvIzh5QeG+FWIBl5lJxWuJszQJSNrG+tLRfHcaRStSHOENt9HaSIiTVtyuFKCpBPePFettQtnKKYeMPzW6eDvjtnB9oxySrH1AZe4WJ7pDtWd6eq1VeQH0czj0mKWwxC9ghojRSUu52lKbuRiYk5swZp7jFVB1fgdhHS0Z81TSyKhGB+sbOj5/hqYUgoTj5IqHByHpPcXajC1CI21kd54obYHntWsZOWkrnoc3yQeX3chBB1mwACO/HWaZ/KDwz5jHDiTJK42OYBY4swIvSymou2chYfCV8/MR1bHYiMAWHclbcC+qTZR7EwOA0tcJzsDD0LK32Rr+6BDc39Nf3gAse6492haD5ouUpBYc7o9c8TgOoXAN2Qx+oyU= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR08MB7201.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39860400002)(366004)(396003)(346002)(136003)(376002)(451199021)(186003)(6506007)(6512007)(53546011)(26005)(478600001)(966005)(6666004)(2616005)(83380400001)(41300700001)(8936002)(5660300002)(44832011)(2906002)(8676002)(316002)(6486002)(54906003)(66946007)(6916009)(66556008)(66476007)(86362001)(4326008)(36756003)(38100700002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6516 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 757a2afd-6842-4374-6d31-08db638381cd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yAxvy/FDPlErdCoHX0uEqRjWtuyaXJKhy/oLoA31ItWY/Mkyxgw2plYo2bCJmqD1puOjpg0sdMNE+fzed4YBLSOHnMi9lHAXixLdJN0xV9PN7bPew++0aBp/bxltDJune2iCVhgGK9pyt62CiYDfHdGUsv0Ue44SY0LAjsCoLXAxVK01uj5Fy1Hen5W1/UKOd02/YPIyjkLEaYIytWzfJ2hc7GjotWvdC1WheCliPlHK9fYMy8P3wzlQzSNjKvVwox6UvYgDd3vN8ysRshYy01XrwmSpYadzzqtODxiEu6cWSL8qYmiGKEdw0oLh07Uv7oI8UtnOzj9CazoQWfCAl6kNvF6X5v1gRFjf/zGAUzNi/g5eJuDCr31rPVqVmz/cKL+a6oomxg+GLg+kEckFSgp51GF6P4CWoEB/FOeHIg0b2DDaptsi5Egxq+GrBwJY7J84jfbjcESbkyX1kL8ZhJ1C0WhgHBFKoqMzc8/YlU3GayNb5q2yYTA5Nb3IaI70qp7L4heTnGInPJqRDst4tkHi8iK3AKcwUKYH2RSmxSevzNjNN4MHobWPFPBfGZIPvTjafaSNKKE6zwr6huzkRXwbTtTpMIk5PQBxyCXzSmbnAZrSR1gfcog0C5ZBO/7nkwhpi9SURV2iue2GVqJ42F3vnmwbiQvMdeH0FwvaaxZ7op2MHSF7ZwGkOcEp1dsannwMoSpyMvZ7S+o7HJKmsB216AjJTepenpbSA86R3/o= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199021)(36840700001)(46966006)(40470700004)(82740400003)(81166007)(82310400005)(356005)(40460700003)(6862004)(86362001)(40480700001)(70586007)(70206006)(4326008)(36756003)(54906003)(478600001)(966005)(6666004)(6512007)(26005)(186003)(6486002)(6506007)(53546011)(2906002)(5660300002)(8936002)(8676002)(44832011)(47076005)(83380400001)(36860700001)(2616005)(336012)(41300700001)(316002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2023 16:07:55.5143 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3f8b6ea0-cb5a-4d65-3977-08db638386b8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT062.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB6664 X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,KAM_DMARC_NONE,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hi Iain, On 02/06/2023 09:32, Iain Sandoe wrote: > Hi David, > > > On 31 May 2023, at 07:13, Indu Bhagat via Gcc-patches wrote: > > > > On 5/30/23 11:27, David Faust wrote: > >> [Changes from v1: > >> - Fix typos. > >> - Split unrelated change into separate commit. > >> - Improve asm comment for enum constants, update btf-enum-1 test. > >> - Improve asm comment for DATASEC records, update btf-datasec-2 test.] > >> Many BTF type kinds refer to other types via index to the final types > >> list. However, the order of the final types list is not guaranteed to > >> remain the same for the same source program between different runs of > >> the compiler, making it difficult to test inter-type references. > >> This patch updates the assembler comments output when writing a > >> given BTF record to include minimal information about the referenced > >> type, if any. This allows for the regular expressions used in the gcc > >> testsuite to do some basic integrity checks on inter-type references. > >> For example, for the type > >> unsigned int * > >> Assembly comments like the following are written with -dA: > >> .4byte 0 ; TYPE 2 BTF_KIND_PTR '' > >> .4byte 0x2000000 ; btt_info: kind=2, kflag=0, vlen=0 > >> .4byte 0x1 ; btt_type: (BTF_KIND_INT 'unsigned int') > >> Several BTF tests which can immediately be made more robust with this > >> change are updated. It will also be useful in new tests for the upcoming > >> btf_type_tag support. > >> Re-tested on BPF and x86_64, no known regressions. > >> Thanks. > > > > LGTM. > > This seems to break bootstrap on x86_64 darwin with two instances of : > > gcc/btfout.cc:802:32: error: format ‘%lu’ expects argument of type ‘long unsigned int’, but argument 4 has type ‘ctf_id_t’ {aka ‘long long unsigned int’} [-Werror=format=] > 802 | "TYPE %lu BTF_KIND_%s '%s’" > > And another on line 970. > > could you suggest where the change should be? I've pushed a fix for this: https://gcc.gnu.org/pipermail/gcc-patches/2023-June/620515.html as g:f2e60a00c7c017bd87ba9afb189cbb77d8c92925. Thanks, Alex > thanks > Iain >