From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 9067E3858C54 for ; Wed, 7 Jun 2023 07:12:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9067E3858C54 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686121934; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=AZ48o+NJiNOE6mmr1TojdCiOGYaNGRjhQNeco/CpfX0=; b=TSwvhA5nAiM72yZDC8Lqjo6sYSE8BLAe+1eKESSzKWhcAKVtrU/j3JhN96NzWYUvd65sTE DjkR9LlwR5YbjpU3VKiV3qbvJE9bQh8M0HfZXK9NAnUKais6m7rBr/3uv7KSg2R4Yg+Dxn qhlgEQADGgUj7YHWxc86kbhaaMO6wtI= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-196-O9p4tq0iNeKijQNsPHrORA-1; Wed, 07 Jun 2023 03:12:10 -0400 X-MC-Unique: O9p4tq0iNeKijQNsPHrORA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 5EC1F101A53B; Wed, 7 Jun 2023 07:12:10 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 227C0406793; Wed, 7 Jun 2023 07:12:10 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 3577C7Fn1359332 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 7 Jun 2023 09:12:08 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 3577C6221359331; Wed, 7 Jun 2023 09:12:06 +0200 Date: Wed, 7 Jun 2023 09:12:06 +0200 From: Jakub Jelinek To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 1/2] Match: zero_one_valued_p should match 0 constants too Message-ID: Reply-To: Jakub Jelinek References: <20230607001706.3000011-1-apinski@marvell.com> MIME-Version: 1.0 In-Reply-To: <20230607001706.3000011-1-apinski@marvell.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jun 06, 2023 at 05:17:05PM -0700, Andrew Pinski via Gcc-patches wrote: > While working on `bool0 ? bool1 : bool2` I noticed that > zero_one_valued_p does not match on the constant zero > as in that case tree_nonzero_bits will return 0 and > that is different from 1. > > OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions. > > gcc/ChangeLog: > > * match.pd (zero_one_valued_p): Match 0 integer constant > too. > --- > gcc/match.pd | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gcc/match.pd b/gcc/match.pd > index f9cbd757752..f97ff7ef760 100644 > --- a/gcc/match.pd > +++ b/gcc/match.pd > @@ -1983,11 +1983,16 @@ DEFINE_INT_AND_FLOAT_ROUND_FN (RINT) > (bit_not (bit_not @0)) > @0) > > +/* zero_one_valued_p will match when a value is known to be either > + 0 or 1 including the constant 0. */ > (match zero_one_valued_p > @0 > (if (INTEGRAL_TYPE_P (type) && tree_nonzero_bits (@0) == 1))) So perhaps instead change this to && wi::leu_p (tree_nonzero_bits (@0), 1) ? > (match zero_one_valued_p > truth_valued_p@0) > +(match zero_one_valued_p > + integer_zerop@0 > + (if (INTEGRAL_TYPE_P (type)))) > > /* Transform { 0 or 1 } * { 0 or 1 } into { 0 or 1 } & { 0 or 1 }. */ > (simplify Jakub