From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x52b.google.com (mail-pg1-x52b.google.com [IPv6:2607:f8b0:4864:20::52b]) by sourceware.org (Postfix) with ESMTPS id 21AF138582BE for ; Tue, 13 Jun 2023 10:14:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 21AF138582BE Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pg1-x52b.google.com with SMTP id 41be03b00d2f7-5440e98616cso3124066a12.0 for ; Tue, 13 Jun 2023 03:14:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686651245; x=1689243245; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IvD4tpcQQ5gj1xr1NimrMPFHCYXR5twE8Kf5bI+DHHg=; b=K+c9Q2IByICjOc2LVuSRTR2vGexJm34oZNkBvvDQ84M+N4PZVA3tUYvv4oCVU4t0QL U4O9m5S69Hny8gCOn7q2jwOqZB5ERr/yqdyR6zMNnVU//VipuYZ5XOgaJfdtCAfNLYg2 4WTlDeshdqvY45rFfYLzphX0ddxHy2/NTPKgZYWccZsqzB/7jOsqBjYY0ZyeRsmCn7v4 5JEk8z8/Rl2JAXphIeUCEiPIC2ve89J3t8iFgfplZydiPi/fHpbTfxI/WYmTKNrgf88F jPk6NSFRaoO1mxmN7BGoRTJ/Cbg0X7rY54gmcTBar1u9xIum1k+IC/KO7gU/ZKPkWzgd F4fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686651245; x=1689243245; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IvD4tpcQQ5gj1xr1NimrMPFHCYXR5twE8Kf5bI+DHHg=; b=k5KUaa8UP94EpyFzR0pIpI0/zZh4dHE9RpNqmZKGqlF5f/wJeNHHzBHgsfQNerWrKV GdSYn80Z6Hd2xfCtHWZo1puvtEMmZWg8aSWdi7M0FQdUtMzm5DUchKrOaqFr4LI5JdvZ I3droxwKGUYPr4m8477lxdDDBPui69ovOR6AE0Tbh6W26FeL6YLCEslfGsLaLTC4OmH+ p+pGqzp7J0Lz9veCCcEkVIJgTOL217shPkHuvutOQuoVY6g0gfBZcM0am5reHYz6CnLu JrUpRriYTHHS7lA0ynnCjpqEY84ODayfBnWAvHhwkYLDiKagiGHRGFgb+Vdsua/mF6rZ tbUg== X-Gm-Message-State: AC+VfDyq54paT18UTqsM2uD/mTVdO9XC8RybG2sg09z44Zhz5EYN03e4 W6Q86Gj7+cCOZSUeHYeJj/xAJ/xLmuw= X-Google-Smtp-Source: ACHHUZ696SJbIJZuWSwJsPyS10t2l2kVjz5UZ7H+gE8NuRDAW0LdPAYCOTXPdtfBC2VjOuYZg4oV5g== X-Received: by 2002:a17:90a:d908:b0:253:6e6f:f5c5 with SMTP id c8-20020a17090ad90800b002536e6ff5c5mr18625523pjv.7.1686651244595; Tue, 13 Jun 2023 03:14:04 -0700 (PDT) Received: from Thaum.localdomain (59-102-120-25.tpgi.com.au. [59.102.120.25]) by smtp.gmail.com with ESMTPSA id 11-20020a17090a1a0b00b0025bfda134ccsm2345238pjk.16.2023.06.13.03.14.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 03:14:04 -0700 (PDT) Date: Tue, 13 Jun 2023 20:14:00 +1000 From: Nathaniel Shead To: gcc-patches@gcc.gnu.org Subject: [PATCH] c++: Fix ICE with parameter pack of decltype(auto) [PR103497] Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,GIT_PATCH_0,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: (Another) ping. https://gcc.gnu.org/pipermail/gcc-patches/2023-April/616465.html On Sat, Apr 22, 2023 at 04:25:13PM +1000, Nathaniel Shead wrote: > Bootstrapped and tested on x86_64-pc-linux-gnu. > > -- 8< -- > > This patch raises an error early when the decltype(auto) specifier is > used as a parameter of a function. This prevents any issues with an > unexpected tree type later on when performing the call. > > PR 103497 > > gcc/cp/ChangeLog: > > * parser.cc (cp_parser_simple_type_specifier): Add check for > decltype(auto) as function parameter. > > gcc/testsuite/ChangeLog: > > * g++.dg/pr103497.C: New test. > > Signed-off-by: Nathaniel Shead > --- > gcc/cp/parser.cc | 10 ++++++++++ > gcc/testsuite/g++.dg/pr103497.C | 7 +++++++ > 2 files changed, 17 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/pr103497.C > > diff --git a/gcc/cp/parser.cc b/gcc/cp/parser.cc > index e5f032f2330..1415e07e152 100644 > --- a/gcc/cp/parser.cc > +++ b/gcc/cp/parser.cc > @@ -19884,6 +19884,16 @@ cp_parser_simple_type_specifier (cp_parser* parser, > && cp_lexer_peek_nth_token (parser->lexer, 2)->type != CPP_SCOPE) > { > type = saved_checks_value (token->u.tree_check_value); > + /* Within a function parameter declaration, decltype(auto) is always an > + error. */ > + if (parser->auto_is_implicit_function_template_parm_p > + && TREE_CODE (type) == TEMPLATE_TYPE_PARM > + && AUTO_IS_DECLTYPE (type)) > + { > + error_at (token->location, > + "cannot declare a parameter with %"); > + type = error_mark_node; > + } > if (decl_specs) > { > cp_parser_set_decl_spec_type (decl_specs, type, > diff --git a/gcc/testsuite/g++.dg/pr103497.C b/gcc/testsuite/g++.dg/pr103497.C > new file mode 100644 > index 00000000000..bcd421c2907 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/pr103497.C > @@ -0,0 +1,7 @@ > +// { dg-do compile { target c++14 } } > + > +void foo(decltype(auto)... args); // { dg-error "parameter with .decltype.auto..|no parameter packs" } > + > +int main() { > + foo(); > +} > -- > 2.34.1 >