From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 37C893858D38 for ; Tue, 13 Jun 2023 14:48:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 37C893858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686667723; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=B8SyRzJ0s/2aXQVVfx/SrGYXlMYEyV8caZ+474gsVn8=; b=WLjAiVLAMDB8W5gLEePit9pruCEcijmI42eolOFgs+dPrGdIz86uMil//tusHgrleBKpsi R2Cw7AWK1btpn88IDiEycfytMz3DfRNz1A3Y+EZ00phgiP4CEWwmMuIQukAGZRXXwHlf4x PuO8GLobqMlD5UkPeU4fpkxjDNcPc6A= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-318-8q2yq2o5PGy7GMO-Y5sACQ-1; Tue, 13 Jun 2023 10:48:36 -0400 X-MC-Unique: 8q2yq2o5PGy7GMO-Y5sACQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4934F81B487; Tue, 13 Jun 2023 14:48:24 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0A5332026833; Tue, 13 Jun 2023 14:48:23 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 35DEmKTJ1617955 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 13 Jun 2023 16:48:21 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 35DEmJVu1617954; Tue, 13 Jun 2023 16:48:19 +0200 Date: Tue, 13 Jun 2023 16:48:19 +0200 From: Jakub Jelinek To: "Andre Vieira (lists)" Cc: Gaius Mulley , Richard Biener , Richard Sandiford , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] modula2: Fix bootstrap Message-ID: Reply-To: Jakub Jelinek References: <37abc128-776c-0f04-f755-30e514909e15@arm.com> <55abff3b-fb69-d2d3-34a7-f86b54c27bc1@arm.com> <2cdf6ac3-3f3d-d006-abd1-3aac5d5fef80@arm.com> MIME-Version: 1.0 In-Reply-To: <2cdf6ac3-3f3d-d006-abd1-3aac5d5fef80@arm.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jun 07, 2023 at 09:42:22AM +0100, Andre Vieira (lists) wrote: > I do need those includes and sorry I broke your bootstrap it didn't show up > on my aarch64-unknown-linux-gnu bootstrap, I'm guessing the rules there were > just run in a different order. Glad you were able to fix it :) Unfortunately, it doesn't really work. My x86_64-linux bootstrap today died again with: In file included from ../../gcc/m2/gm2-gcc/gcc-consolidation.h:74, from ../../gcc/m2/gm2-lang.cc:24: ../../gcc/internal-fn.h:24:10: fatal error: insn-opinit.h: No such file or directory 24 | #include "insn-opinit.h" | ^~~~~~~~~~~~~~~ compilation terminated. /home/jakub/src/gcc/obj36/./prev-gcc/xg++ -B/home/jakub/src/gcc/obj36/./prev-gcc/ -B/usr/local/x86_64-pc-linux-gnu/bin/ -nostdinc++ -B/home/jakub/src/gcc/obj36/prev-x86_64-pc-linux-gnu/libstdc++-v3/src/.libs -B/home/jakub/src/gcc/obj36/prev-x86_64-pc-linux-gnu/libstdc++-v3/libsupc++/.libs -I/home/jakub/src/gcc/obj36/prev-x86_64-pc-linux-gnu/libstdc++-v3/include/x86_64-pc-linux-gnu -I/home/jakub/src/gcc/obj36/prev-x86_64-pc-linux-gnu/libstdc++-v3/include -I/home/jakub/src/gcc/libstdc++-v3/libsupc++ -L/home/jakub/src/gcc/obj36/prev-x86_64-pc-linux-gnu/libstdc++-v3/src/.libs -L/home/jakub/src/gcc/obj36/prev-x86_64-pc-linux-gnu/libstdc++-v3/libsupc++/.libs -fno-PIE -c -g -g -O2 -fchecking=1 -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -fno-common -DHAVE_CONFIG_H \ -I. -Im2/gm2-gcc -I../../gcc -I../../gcc/m2/gm2-gcc -I../../gcc/../include -I../../gcc/../libcpp/include -I../../gcc/../libcody -I../../gcc/../libdecnumber -I../../gcc/../libdecnumber/bid -I../libdecnumber -I../../gcc/../libbacktrace -I. -Im2/gm2-gcc -I../../gcc -I../../gcc/m2/gm2-gcc -I../../gcc/../include -I../../gcc/../libcpp/include -I../../gcc/../libcody -I../../gcc/../libdecnumber -I../../gcc/../libdecnumber/bid -I../libdecnumber -I../../gcc/../libbacktrace ../../gcc/m2/gm2-gcc/m2type.cc -o m2/gm2-gcc/m2type.o make[3]: *** [../../gcc/m2/Make-lang.in:570: m2/gm2-lang.o] Error 1 make[3]: *** Waiting for unfinished jobs.... errors. Dunno what is going on. I've tried --- gcc/m2/Make-lang.in.jj 2023-06-07 15:56:07.112684198 +0200 +++ gcc/m2/Make-lang.in 2023-06-13 16:08:55.409364765 +0200 @@ -511,7 +511,7 @@ GM2_LIBS_BOOT = m2/gm2-compiler-boot m2/gm2-libs-boot/libgm2.a \ $(GM2-BOOT-O) -$(GM2_C_OBJS) : | $(generated_files) +m2_OBJS = $(GM2_C_OBJS) cc1gm2$(exeext): m2/stage1/cc1gm2$(exeext) $(m2.prev) cp -p $< $@ but that doesn't really work either, this time not just random bootstrap breakages from time to time, but all the time. Including GM2_C_OBJS in m2_OBJS is I think the right thing, but that results in predefining IN_GCC_FRONTEND macro and we have e.g. /* Front ends should never have to include middle-end headers. Enforce this by poisoning the header double-include protection defines. */ #ifdef IN_GCC_FRONTEND #pragma GCC poison GCC_RTL_H GCC_EXCEPT_H GCC_EXPR_H #endif in system.h to make sure that FE sources don't include rtl.h, except.h, expr.h. But m2/gm2-gcc/gcc-consolidation.h includes tons of the RTL headers, rtl.h, df.h (twice), except.h; why? Also, seems one of GM2_C_OBJS is some special copy of stor-layout.cc which really isn't a FE file and so needs the RTL-ish headers. Jakub