From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Harald Anlauf via Fortran <fortran@gcc.gnu.org>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fortran: fix passing of zero-sized array arguments to procedures [PR86277]
Date: Tue, 13 Jun 2023 10:45:17 -0700 [thread overview]
Message-ID: <ZIirLYOF2tA4h+32@troutmask.apl.washington.edu> (raw)
In-Reply-To: <trinity-ee69c69e-7b4c-48d6-8f89-a5c4467fd9e6-1686604365454@3c-app-gmx-bs01>
On Mon, Jun 12, 2023 at 11:12:45PM +0200, Harald Anlauf via Fortran wrote:
> Dear all,
>
> the attached - actually rather small - patch is the result of a
> rather intensive session with Mikael in an attempt to fix the
> situation that we did not create proper temporaries when passing
> zero-sized array arguments to procedures. When the dummy argument
> was declared as OPTIONAL, in many cases it was mis-detected as
> non-present. This also depended on the type of argument, and
> was different for different intrinsic types, notably character,
> and derived types, and should explain the rather large ratio of
> the size of the provided testcases to the actual fix...
>
> (What the patch does not address: we still generate too much code
> for unneeded temporaries, often two temporaries instead of just
> one. I'll open a separate PR to track this.)
>
> Regtested on x86_64-pc-linux-gnu. OK for mainline?
>
> If this survives long enough on 14-trunk, would this be eligible
> for a backport to 13-branch in time for 13.2?
>
OK to commit.
I've reviewed the bugzilla exchange between Mikael and you,
and agree with committing this and opening a new PR to
track the unneeded temporaries issue.
--
Steve
next prev parent reply other threads:[~2023-06-13 17:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-12 21:12 Harald Anlauf
2023-06-13 17:45 ` Steve Kargl [this message]
2023-06-13 19:33 ` Harald Anlauf
2023-06-13 19:33 ` Harald Anlauf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZIirLYOF2tA4h+32@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).