From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 13DD83858C20 for ; Wed, 14 Jun 2023 14:56:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 13DD83858C20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686754589; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=dQfPOMrvStxPwGeXAV2uEi8kwMuQ1d1Yl/SVesg+NhM=; b=ZN7ipPzy+SzTq8k7mk7Y0Wo4SQQRvbhFW1CopCTOEe1QREmLhu4jpaGgjr/0xlwi0Rm5Yy ftNvqQFJfWTZBjN8iCa+6IqxWKKOkXFL/C7wZufeom/Ad1HBWQUtH0OC/Vp4lAdY5OCqe5 qqdj+uuY9o6+5iU8AWmbUYpq4OAbX7w= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-32-J1kqkvDHNxK1s6UjJPF-jg-1; Wed, 14 Jun 2023 10:56:26 -0400 X-MC-Unique: J1kqkvDHNxK1s6UjJPF-jg-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1FD75101AA47; Wed, 14 Jun 2023 14:56:26 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.194.30]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B81B240C20F4; Wed, 14 Jun 2023 14:56:25 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 35EEuMX31150187 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 14 Jun 2023 16:56:23 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 35EEuMH01150186; Wed, 14 Jun 2023 16:56:22 +0200 Date: Wed, 14 Jun 2023 16:56:21 +0200 From: Jakub Jelinek To: Uros Bizjak Cc: Richard Biener , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] middle-end, i386, v3: Pattern recognize add/subtract with carry [PR79173] Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jun 14, 2023 at 04:34:27PM +0200, Uros Bizjak wrote: > LGTM for the x86 part. I did my best, but those peephole2 patterns are > real PITA to be reviewed thoroughly. > > Maybe split out peephole2 pack to a separate patch, followed by a > testcase patch. This way, bisection would be able to point out if a > generic part or target-dependent part caused eventual regression. Ok. Guess if it helps for bisection, I could even split the peephole2s to one peephole2 addition per commit and then the final patch would add the expanders and the generic code. Jakub