From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E07193858D3C for ; Fri, 16 Jun 2023 12:32:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E07193858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686918737; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=FCfFvxUqZM3r6Iohf8NZzklkxABH9N+T7sp1rDqJR18=; b=HzgRh5f1PYiJ9Mbji2VDR1Yw+snvIRT+s7BYj5SXF6An+pbWbYsR++0URWPCggzQwpCLD0 xfDuqW9r0dzg1mASNmMVhsfoEIrgzKFUXNg0oQYOO63HbWUiV9pzQKfWkgK77DLG/8rwkw 6n5GdLyWfqQo0abIB5IRUlqcxYptrR0= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-561--VG2689DNZWhaaB8TOZRVA-1; Fri, 16 Jun 2023 08:32:16 -0400 X-MC-Unique: -VG2689DNZWhaaB8TOZRVA-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-75d59ed75e2so109591285a.2 for ; Fri, 16 Jun 2023 05:32:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686918735; x=1689510735; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FCfFvxUqZM3r6Iohf8NZzklkxABH9N+T7sp1rDqJR18=; b=YBc5VLjHoaZbXtXrX2X9oAFgCwVwFHKpA8r8iWegPzus1LhQDaZCGFtNmIY8ygYe7e iFgjWVjWSupqfhxMgds1HS8GpepmvRdspxfitewsFUTIxKZjW/m6rxaRlxFv2xPVkWWd 0AcYDeSCPnCzro+nxFaZo9MMIgrGCYsAqriZxZFtPnkWbqHwnrW+Tbhyzw0mgg3de1ZR HBr9V8iJyqe4DSmjyhtqLVj5OkTYbIOZmnA8xYiNdmJUs6Va5rGoVbED/GCUePQk18ZP HNzAySVpeE+5YctGnKxjS5zPb1WBKtD0p/ogMMA7IzNspPpA+o36HSmgV9B7HjsFMC2e OzbA== X-Gm-Message-State: AC+VfDx5YqWW9RuTSPctt9bhv8/qeZ/8ICv+88na3ouz8oLkpqTj6CwT HpdkWlWMD10Tql1+S1Hs/u3TVBgqk33C7zY3PmeYk6BAZI4s/3BcEanvKcTFaiqkm/3RB0fnmhB mq0q2+2JWVSDLLOk94e54FXJEHA== X-Received: by 2002:a05:620a:f14:b0:762:1f0a:5530 with SMTP id v20-20020a05620a0f1400b007621f0a5530mr1724070qkl.6.1686918735235; Fri, 16 Jun 2023 05:32:15 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5nopd3zT4bMP2+DIB0QD3e3mabq5gmU2jPjCKq5HGu/KowlyhoULvg5xwnxIZKT7ctYL6sNA== X-Received: by 2002:a05:620a:f14:b0:762:1f0a:5530 with SMTP id v20-20020a05620a0f1400b007621f0a5530mr1724053qkl.6.1686918734923; Fri, 16 Jun 2023 05:32:14 -0700 (PDT) Received: from redhat.com (2603-7000-9500-34a5-0000-0000-0000-1db4.res6.spectrum.com. [2603:7000:9500:34a5::1db4]) by smtp.gmail.com with ESMTPSA id g25-20020a05620a13d900b007577ccf566asm6434765qkl.93.2023.06.16.05.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jun 2023 05:32:13 -0700 (PDT) Date: Fri, 16 Jun 2023 08:32:10 -0400 From: Marek Polacek To: Martin Jambor Cc: GCC Patches Subject: Re: [PATCH v3] configure: Implement --enable-host-pie Message-ID: References: <20230509194158.329137-1-polacek@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Jun 16, 2023 at 12:26:23PM +0200, Martin Jambor wrote: > Hello, > > On Thu, Jun 15 2023, Marek Polacek via Gcc-patches wrote: > > On Mon, Jun 05, 2023 at 09:06:43PM -0600, Jeff Law wrote: > >> > >> > >> On 6/5/23 10:18, Marek Polacek via Gcc-patches wrote: > >> > Ping. Anyone have any further comments? > >> Given this was approved before, but got reverted due to issues (which have > >> since been addressed) -- I think you might as well go forward and sooner > >> rather than later so that we can catch fallout earlier. > > > > Thanks, pushed now, after rebasing, adjusting the patch for > > r14-1385, and testing with and without --enable-host-pie on > > both Debian and Fedora. > > > > If something comes up and I can't fix it quickly enough, I'll > > have to revert the patch. We'll see. > > > > The script that regularly checks that the checked-in autotools-generated > files are in sync now complain about the following diff. Unless someone > stops me because I overlooked something or for some other reason, I will > commit it later on as obvious. Please, go ahead. > I wonder where the "line" differences come from, perhaps you added a > comment after running autoconf/automake/...? The zlib/Makefile.in hunks Arg, I think I must've messed up the #lines when rebasing though I don't know what went wrong with zlib/Makefile.in. But I don't think the latter will actually make any difference. > like something we should have, though, even if I did not check whether > it makes any difference in practice. And I want the checking script to > shut up too ;-) Thanks and sorry. > Thanks, > > Martin > > > diff --git a/gcc/configure b/gcc/configure > index a4563a9cade..f7b4b283ca2 100755 > --- a/gcc/configure > +++ b/gcc/configure > @@ -19847,7 +19847,7 @@ else > lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 > lt_status=$lt_dlunknown > cat > conftest.$ac_ext <<_LT_EOF > -#line 19848 "configure" > +#line 19850 "configure" > #include "confdefs.h" > > #if HAVE_DLFCN_H > @@ -19953,7 +19953,7 @@ else > lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 > lt_status=$lt_dlunknown > cat > conftest.$ac_ext <<_LT_EOF > -#line 19954 "configure" > +#line 19956 "configure" > #include "confdefs.h" > > #if HAVE_DLFCN_H > diff --git a/zlib/Makefile.in b/zlib/Makefile.in > index 3f5102d1b87..80fe3b69116 100644 > --- a/zlib/Makefile.in > +++ b/zlib/Makefile.in > @@ -353,6 +353,8 @@ datadir = @datadir@ > datarootdir = @datarootdir@ > docdir = @docdir@ > dvidir = @dvidir@ > +enable_host_pie = @enable_host_pie@ > +enable_host_shared = @enable_host_shared@ > exec_prefix = @exec_prefix@ > host = @host@ > host_alias = @host_alias@ > diff --git a/zlib/configure b/zlib/configure > index 77be6c284e3..9308866a636 100755 > --- a/zlib/configure > +++ b/zlib/configure > @@ -10763,7 +10763,7 @@ else > lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 > lt_status=$lt_dlunknown > cat > conftest.$ac_ext <<_LT_EOF > -#line 10778 "configure" > +#line 10766 "configure" > #include "confdefs.h" > > #if HAVE_DLFCN_H > @@ -10869,7 +10869,7 @@ else > lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2 > lt_status=$lt_dlunknown > cat > conftest.$ac_ext <<_LT_EOF > -#line 10884 "configure" > +#line 10872 "configure" > #include "confdefs.h" > > #if HAVE_DLFCN_H > Marek