* [PATCH] i386: add -fno-stack-protector to two tests
@ 2023-06-29 20:01 Marek Polacek
2023-06-29 20:08 ` Xi Ruoyao
2023-06-29 20:10 ` Jakub Jelinek
0 siblings, 2 replies; 6+ messages in thread
From: Marek Polacek @ 2023-06-29 20:01 UTC (permalink / raw)
To: GCC Patches
These tests fail when the testsuite is executed with -fstack-protector-strong.
To avoid this, this patch adds -fno-stack-protector to dg-options.
Tested on x86_64-pc-linux-gnu, ok for trunk?
gcc/testsuite/ChangeLog:
* gcc.target/i386/pr104610.c: Use -fno-stack-protector.
* gcc.target/i386/pr69482-1.c: Likewise.
---
gcc/testsuite/gcc.target/i386/pr104610.c | 2 +-
gcc/testsuite/gcc.target/i386/pr69482-1.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.target/i386/pr104610.c b/gcc/testsuite/gcc.target/i386/pr104610.c
index fe39cbe5b8a..5173fc8898c 100644
--- a/gcc/testsuite/gcc.target/i386/pr104610.c
+++ b/gcc/testsuite/gcc.target/i386/pr104610.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-O2 -mavx -mmove-max=256 -mstore-max=256" } */
+/* { dg-options "-O2 -mavx -mmove-max=256 -mstore-max=256 -fno-stack-protector" } */
/* { dg-final { scan-assembler-times {(?n)vptest.*ymm} 1 } } */
/* { dg-final { scan-assembler-times {sete} 1 } } */
/* { dg-final { scan-assembler-not {(?n)je.*L[0-9]} } } */
diff --git a/gcc/testsuite/gcc.target/i386/pr69482-1.c b/gcc/testsuite/gcc.target/i386/pr69482-1.c
index f192261b104..99bb6ad5a37 100644
--- a/gcc/testsuite/gcc.target/i386/pr69482-1.c
+++ b/gcc/testsuite/gcc.target/i386/pr69482-1.c
@@ -1,5 +1,5 @@
/* { dg-do compile } */
-/* { dg-options "-O3" } */
+/* { dg-options "-O3 -fno-stack-protector" } */
static inline void memset_s(void* s, int n) {
volatile unsigned char * p = s;
base-commit: 070a6bf0bdc6761ad77ac97404c98f00a7007d54
--
2.41.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i386: add -fno-stack-protector to two tests
2023-06-29 20:01 [PATCH] i386: add -fno-stack-protector to two tests Marek Polacek
@ 2023-06-29 20:08 ` Xi Ruoyao
2023-06-29 20:11 ` Xi Ruoyao
2023-06-29 20:10 ` Jakub Jelinek
1 sibling, 1 reply; 6+ messages in thread
From: Xi Ruoyao @ 2023-06-29 20:08 UTC (permalink / raw)
To: Marek Polacek, GCC Patches
On Thu, 2023-06-29 at 16:01 -0400, Marek Polacek via Gcc-patches wrote:
> These tests fail when the testsuite is executed with -fstack-
> protector-strong.
> To avoid this, this patch adds -fno-stack-protector to dg-options.
>
> Tested on x86_64-pc-linux-gnu, ok for trunk?
LGTM, we've noticed these two failures in Linux From Scratch [1]. But
this is not an approval because I'm not a maintainer.
[1]:https://www.linuxfromscratch.org/lfs/view/development/chapter08/gcc.html
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/i386/pr104610.c: Use -fno-stack-protector.
> * gcc.target/i386/pr69482-1.c: Likewise.
> ---
> gcc/testsuite/gcc.target/i386/pr104610.c | 2 +-
> gcc/testsuite/gcc.target/i386/pr69482-1.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/testsuite/gcc.target/i386/pr104610.c
> b/gcc/testsuite/gcc.target/i386/pr104610.c
> index fe39cbe5b8a..5173fc8898c 100644
> --- a/gcc/testsuite/gcc.target/i386/pr104610.c
> +++ b/gcc/testsuite/gcc.target/i386/pr104610.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-O2 -mavx -mmove-max=256 -mstore-max=256" } */
> +/* { dg-options "-O2 -mavx -mmove-max=256 -mstore-max=256 -fno-stack-
> protector" } */
> /* { dg-final { scan-assembler-times {(?n)vptest.*ymm} 1 } } */
> /* { dg-final { scan-assembler-times {sete} 1 } } */
> /* { dg-final { scan-assembler-not {(?n)je.*L[0-9]} } } */
> diff --git a/gcc/testsuite/gcc.target/i386/pr69482-1.c
> b/gcc/testsuite/gcc.target/i386/pr69482-1.c
> index f192261b104..99bb6ad5a37 100644
> --- a/gcc/testsuite/gcc.target/i386/pr69482-1.c
> +++ b/gcc/testsuite/gcc.target/i386/pr69482-1.c
> @@ -1,5 +1,5 @@
> /* { dg-do compile } */
> -/* { dg-options "-O3" } */
> +/* { dg-options "-O3 -fno-stack-protector" } */
>
> static inline void memset_s(void* s, int n) {
> volatile unsigned char * p = s;
>
> base-commit: 070a6bf0bdc6761ad77ac97404c98f00a7007d54
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i386: add -fno-stack-protector to two tests
2023-06-29 20:01 [PATCH] i386: add -fno-stack-protector to two tests Marek Polacek
2023-06-29 20:08 ` Xi Ruoyao
@ 2023-06-29 20:10 ` Jakub Jelinek
1 sibling, 0 replies; 6+ messages in thread
From: Jakub Jelinek @ 2023-06-29 20:10 UTC (permalink / raw)
To: Marek Polacek; +Cc: GCC Patches
On Thu, Jun 29, 2023 at 04:01:20PM -0400, Marek Polacek via Gcc-patches wrote:
> These tests fail when the testsuite is executed with -fstack-protector-strong.
> To avoid this, this patch adds -fno-stack-protector to dg-options.
>
> Tested on x86_64-pc-linux-gnu, ok for trunk?
>
> gcc/testsuite/ChangeLog:
>
> * gcc.target/i386/pr104610.c: Use -fno-stack-protector.
> * gcc.target/i386/pr69482-1.c: Likewise.
Ok, thanks.
Jakub
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i386: add -fno-stack-protector to two tests
2023-06-29 20:08 ` Xi Ruoyao
@ 2023-06-29 20:11 ` Xi Ruoyao
2023-06-29 20:13 ` Jakub Jelinek
2023-06-29 20:13 ` Marek Polacek
0 siblings, 2 replies; 6+ messages in thread
From: Xi Ruoyao @ 2023-06-29 20:11 UTC (permalink / raw)
To: Marek Polacek, GCC Patches
On Fri, 2023-06-30 at 04:08 +0800, Xi Ruoyao wrote:
> On Thu, 2023-06-29 at 16:01 -0400, Marek Polacek via Gcc-patches wrote:
> > These tests fail when the testsuite is executed with -fstack-
> > protector-strong.
> > To avoid this, this patch adds -fno-stack-protector to dg-options.
> >
> > Tested on x86_64-pc-linux-gnu, ok for trunk?
>
> LGTM, we've noticed these two failures in Linux From Scratch [1]. But
> this is not an approval because I'm not a maintainer.
And can we backport them to gcc-13 branch too? These two tests were
added in the cycle of GCC 13, so we could consider the failures
"regression".
>
> [1]:https://www.linuxfromscratch.org/lfs/view/development/chapter08/gcc.html
>
> >
> > gcc/testsuite/ChangeLog:
> >
> > * gcc.target/i386/pr104610.c: Use -fno-stack-protector.
> > * gcc.target/i386/pr69482-1.c: Likewise.
> > ---
> > gcc/testsuite/gcc.target/i386/pr104610.c | 2 +-
> > gcc/testsuite/gcc.target/i386/pr69482-1.c | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/gcc/testsuite/gcc.target/i386/pr104610.c
> > b/gcc/testsuite/gcc.target/i386/pr104610.c
> > index fe39cbe5b8a..5173fc8898c 100644
> > --- a/gcc/testsuite/gcc.target/i386/pr104610.c
> > +++ b/gcc/testsuite/gcc.target/i386/pr104610.c
> > @@ -1,5 +1,5 @@
> > /* { dg-do compile } */
> > -/* { dg-options "-O2 -mavx -mmove-max=256 -mstore-max=256" } */
> > +/* { dg-options "-O2 -mavx -mmove-max=256 -mstore-max=256 -fno-stack-
> > protector" } */
> > /* { dg-final { scan-assembler-times {(?n)vptest.*ymm} 1 } } */
> > /* { dg-final { scan-assembler-times {sete} 1 } } */
> > /* { dg-final { scan-assembler-not {(?n)je.*L[0-9]} } } */
> > diff --git a/gcc/testsuite/gcc.target/i386/pr69482-1.c
> > b/gcc/testsuite/gcc.target/i386/pr69482-1.c
> > index f192261b104..99bb6ad5a37 100644
> > --- a/gcc/testsuite/gcc.target/i386/pr69482-1.c
> > +++ b/gcc/testsuite/gcc.target/i386/pr69482-1.c
> > @@ -1,5 +1,5 @@
> > /* { dg-do compile } */
> > -/* { dg-options "-O3" } */
> > +/* { dg-options "-O3 -fno-stack-protector" } */
> >
> > static inline void memset_s(void* s, int n) {
> > volatile unsigned char * p = s;
> >
> > base-commit: 070a6bf0bdc6761ad77ac97404c98f00a7007d54
>
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i386: add -fno-stack-protector to two tests
2023-06-29 20:11 ` Xi Ruoyao
@ 2023-06-29 20:13 ` Jakub Jelinek
2023-06-29 20:13 ` Marek Polacek
1 sibling, 0 replies; 6+ messages in thread
From: Jakub Jelinek @ 2023-06-29 20:13 UTC (permalink / raw)
To: Xi Ruoyao; +Cc: Marek Polacek, GCC Patches
On Fri, Jun 30, 2023 at 04:11:44AM +0800, Xi Ruoyao via Gcc-patches wrote:
> On Fri, 2023-06-30 at 04:08 +0800, Xi Ruoyao wrote:
> > On Thu, 2023-06-29 at 16:01 -0400, Marek Polacek via Gcc-patches wrote:
> > > These tests fail when the testsuite is executed with -fstack-
> > > protector-strong.
> > > To avoid this, this patch adds -fno-stack-protector to dg-options.
> > >
> > > Tested on x86_64-pc-linux-gnu, ok for trunk?
> >
> > LGTM, we've noticed these two failures in Linux From Scratch [1]. But
> > this is not an approval because I'm not a maintainer.
>
> And can we backport them to gcc-13 branch too? These two tests were
> added in the cycle of GCC 13, so we could consider the failures
> "regression".
It is ok even for 13 branch.
Jakub
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] i386: add -fno-stack-protector to two tests
2023-06-29 20:11 ` Xi Ruoyao
2023-06-29 20:13 ` Jakub Jelinek
@ 2023-06-29 20:13 ` Marek Polacek
1 sibling, 0 replies; 6+ messages in thread
From: Marek Polacek @ 2023-06-29 20:13 UTC (permalink / raw)
To: Xi Ruoyao; +Cc: GCC Patches
On Fri, Jun 30, 2023 at 04:11:44AM +0800, Xi Ruoyao wrote:
> On Fri, 2023-06-30 at 04:08 +0800, Xi Ruoyao wrote:
> > On Thu, 2023-06-29 at 16:01 -0400, Marek Polacek via Gcc-patches wrote:
> > > These tests fail when the testsuite is executed with -fstack-
> > > protector-strong.
> > > To avoid this, this patch adds -fno-stack-protector to dg-options.
> > >
> > > Tested on x86_64-pc-linux-gnu, ok for trunk?
> >
> > LGTM, we've noticed these two failures in Linux From Scratch [1]. But
> > this is not an approval because I'm not a maintainer.
Thanks.
> And can we backport them to gcc-13 branch too? These two tests were
> added in the cycle of GCC 13, so we could consider the failures
> "regression".
Yeah, it would be good for Fedora gcc as well. I'll put the patch in 13
as well.
Marek
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-06-29 20:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-29 20:01 [PATCH] i386: add -fno-stack-protector to two tests Marek Polacek
2023-06-29 20:08 ` Xi Ruoyao
2023-06-29 20:11 ` Xi Ruoyao
2023-06-29 20:13 ` Jakub Jelinek
2023-06-29 20:13 ` Marek Polacek
2023-06-29 20:10 ` Jakub Jelinek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).