From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B47F73858D28 for ; Tue, 27 Jun 2023 09:47:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B47F73858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1687859236; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=Xc0TCBpIwe6a9egeXlLGvehmJmq5N+BiDvmJnrJzmZE=; b=D4wy7y78PCsOnMFlV1FQ3zDpnZQRUHq8Tk/yD7YGXYH8sZ6v76vViYy4lkgCIbV6m+GuSv DBfS8z+1h6Vh60ngogS/sNz6XwScaKa4YkvJkpSR3ScGUwecv3Xm52ZrcdTnYrlTl6WFN+ bq7oclqaHitMYM1KOY4z88jv2ow0OXo= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-410-2FqM-2J7O5yqRRhicSDfCg-1; Tue, 27 Jun 2023 05:47:10 -0400 X-MC-Unique: 2FqM-2J7O5yqRRhicSDfCg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 252C1282381F; Tue, 27 Jun 2023 09:47:10 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.195.172]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DC50640D1A4; Tue, 27 Jun 2023 09:47:09 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 35R9l6L84185488 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 27 Jun 2023 11:47:07 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 35R9l6jl4185487; Tue, 27 Jun 2023 11:47:06 +0200 Date: Tue, 27 Jun 2023 11:47:05 +0200 From: Jakub Jelinek To: Richard Biener Cc: gcc-patches@gcc.gnu.org, jeffreyalaw@gmail.com Subject: Re: [PATCH] Prevent TYPE_PRECISION on VECTOR_TYPEs Message-ID: Reply-To: Jakub Jelinek References: <20230627094533.C82C713462@imap2.suse-dmz.suse.de> MIME-Version: 1.0 In-Reply-To: <20230627094533.C82C713462@imap2.suse-dmz.suse.de> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Jun 27, 2023 at 11:45:33AM +0200, Richard Biener wrote: > The following makes sure that using TYPE_PRECISION on VECTOR_TYPE > ICEs when tree checking is enabled. This should avoid wrong-code > in cases like PR110182 and instead ICE. > > It also introduces a TYPE_PRECISION_RAW accessor and adjusts > places I found that are eligible to use that. > > Bootstrapped and tested on x86_64-unknown-linux-gnu with all > languages enabled. > > OK for trunk? There is definitely going to be fallout but it > should be straight-forward to fix with quick fixes using > TYPE_PRECISION_RAW possible. > > Thanks, > Richard. > > * tree.h (TYPE_PRECISION): Check for non-VECTOR_TYPE. > (TYPE_PRECISION_RAW): Provide raw access to the precision > field. > * tree.cc (verify_type_variant): Compare TYPE_PRECISION_RAW. > (gimple_canonical_types_compatible_p): Likewise. > * tree-streamer-out.cc (pack_ts_type_common_value_fields): > Stream TYPE_PRECISION_RAW. > * tree-streamer-in.cc (unpack_ts_type_common_value_fields): > Likewise. > * lto-streamer-out.cc (hash_tree): Hash TYPE_PRECISION_RAW. > > gcc/lto/ > * lto-common.cc (compare_tree_sccs_1): Use TYPE_PRECISION_RAW. LGTM. Jakub