From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from nikam.ms.mff.cuni.cz (nikam.ms.mff.cuni.cz [195.113.20.16]) by sourceware.org (Postfix) with ESMTPS id 38F44385781F for ; Tue, 4 Jul 2023 14:33:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 38F44385781F Authentication-Results: sourceware.org; dmarc=fail (p=none dis=none) header.from=ucw.cz Authentication-Results: sourceware.org; spf=none smtp.mailfrom=kam.mff.cuni.cz Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id AB1AF281AB9; Tue, 4 Jul 2023 16:33:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ucw.cz; s=gen1; t=1688481201; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pApKxUSus0bqmQcQHP43P+lMlcalM+1LfiSU5qpw7tE=; b=gyfoo87yw/lXggTIahFUpRlK8SPcKYNoIQ7vPdG1hQfmssuBA0iUNjxqoAaE/Agsj/mMx1 DQKzeFuPu+53gxRdRSOth2MQEMgvV7bjGBi6A/3yyve6Fy9+xgYXkMqxihbrB0rDf2DqHj rf4YC7TLZW6mV4Aith7jzxAiH9kd64o= Date: Tue, 4 Jul 2023 16:33:21 +0200 From: Jan Hubicka To: Filip Kastl Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] value-prof.cc: Correct edge prob calculation. Message-ID: References: <20230615095052.13119-1-filip.kastl@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230615095052.13119-1-filip.kastl@gmail.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > The mod-subtract optimization with ncounts==1 produced incorrect edge > probabilities due to incorrect conditional probability calculation. This > patch fixes the calculation. > > gcc/ChangeLog: > > * value-prof.cc (gimple_mod_subtract_transform): Correct edge > prob calculation. OK, thanks! Honza