From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6FFDA3858426 for ; Thu, 6 Jul 2023 19:51:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6FFDA3858426 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688673113; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=s8K2NPypila1ArwrmOpg1pFluH8RI3UkH4CIaZJI/E0=; b=fMAsWs3NOKp8za3Ig6ov3CmhD8ODUUwrJ+n/dOjXO1h4EfdOOInx33nPzEDCDPjTXixR7Q MQvI19Fer8at1laSZhw7Qs61lpmpesAe3wx9prEBs6aRZu2JiTFE2YbE1WQsrkn/x8HYOT tmNOyNTFg2fpzxYsYwehgiizyDNdu88= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-500-Ctkneuq1Niy2O4IRh2gzTg-1; Thu, 06 Jul 2023 15:51:49 -0400 X-MC-Unique: Ctkneuq1Niy2O4IRh2gzTg-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 84C138022EF; Thu, 6 Jul 2023 19:51:49 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.167]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 495AB492C13; Thu, 6 Jul 2023 19:51:49 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 366JpklD3717885 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 6 Jul 2023 21:51:47 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 366Jpki93717882; Thu, 6 Jul 2023 21:51:46 +0200 Date: Thu, 6 Jul 2023 21:51:46 +0200 From: Jakub Jelinek To: Richard Biener Cc: Drew Ross , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] match.pd: Implement missed optimization (~X | Y) ^ X -> ~(X & Y) [PR109986] Message-ID: Reply-To: Jakub Jelinek References: <20230705134147.13325-1-drross@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Jul 06, 2023 at 03:00:28PM +0200, Richard Biener via Gcc-patches wrote: > > + (if (types_match (type, @1)) > > + (bit_not (bit_and @1 (convert @0))) > > + (if (types_match (type, @0)) > > + (bit_not (bit_and (convert @1) @0)) > > + (convert (bit_not (bit_and @0 (convert @1))))))) > > You can elide the types_match checks and instead always emit > > (convert (bit_not (bit_and @0 (convert @1))) > > the conversions are elided when the types match. If all types match, sure, any of the variants will be good. But if say @1 matches type and doesn't match @0, then (convert (bit_not (bit_and @0 (convert @1))) will result in 2 conversions instead of just 1. Of course, it could be alternatively solved by some other simplify that would reduce the number of conversions. Jakub