From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 01DA83858CDA for ; Mon, 10 Jul 2023 22:25:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 01DA83858CDA Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linux.ibm.com Received: from pps.filterd (m0353727.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36AMHCUP004025; Mon, 10 Jul 2023 22:25:57 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=pp1; bh=hTEWvG4E8nmySQ6gUlT0Hys9Yy2Z9ARs/6XAUfuQ05g=; b=USvYqQSNXeVYcvVlvtAhguGcwfOuXCw1lBp5SrQd5s4lDIFARU0hRcHwIhp2L8JT1mmL Oa0nZcYXgzNYFIILZDeGulKAjZpCA0nYSmIqz0ZDLuav4GKKJJ5QEislBbqT86d+A0OG 5/vb7urvvc1gjHvKe9kFsZTcLsYRSqd9TppwI+B3m7QRDC2S2YIM++ejVcbF7TpyyLGz LouyY4BlV4pfsXO6oi66dsVhR4LP4LjTjJDsyoWllgEX0uaQSCS3TnqPSFVFLfcfJbpm 37tAiO8Zz2GapoO+CJLZJKkZsGusUSznqkqekvMophIHaC4zCXYPJjTkPRwlaboReclI Xg== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rrtn5r4r1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Jul 2023 22:25:56 +0000 Received: from m0353727.ppops.net (m0353727.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 36AMLrP4016076; Mon, 10 Jul 2023 22:25:56 GMT Received: from ppma04dal.us.ibm.com (7a.29.35a9.ip4.static.sl-reverse.com [169.53.41.122]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3rrtn5r4qk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Jul 2023 22:25:56 +0000 Received: from pps.filterd (ppma04dal.us.ibm.com [127.0.0.1]) by ppma04dal.us.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 36AJaF3X016682; Mon, 10 Jul 2023 22:25:55 GMT Received: from smtprelay06.dal12v.mail.ibm.com ([9.208.130.100]) by ppma04dal.us.ibm.com (PPS) with ESMTPS id 3rpye62gtb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 10 Jul 2023 22:25:55 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay06.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 36AMPsJN65143102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 10 Jul 2023 22:25:54 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 002D95805A; Mon, 10 Jul 2023 22:25:54 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 893BF58051; Mon, 10 Jul 2023 22:25:53 +0000 (GMT) Received: from cowardly-lion.the-meissners.org (unknown [9.61.34.183]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTPS; Mon, 10 Jul 2023 22:25:53 +0000 (GMT) Date: Mon, 10 Jul 2023 18:25:52 -0400 From: Michael Meissner To: Segher Boessenkool Cc: Michael Meissner , gcc-patches@gcc.gnu.org, "Kewen.Lin" , David Edelsohn , Peter Bergner Subject: Re: [PATCH] Fix typo in insn name. Message-ID: Mail-Followup-To: Michael Meissner , Segher Boessenkool , gcc-patches@gcc.gnu.org, "Kewen.Lin" , David Edelsohn , Peter Bergner References: <20230710201021.GX19790@gate.crashing.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230710201021.GX19790@gate.crashing.org> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: OgeZPOp70E8yf6bDNVUPQJn2lkjP1DJs X-Proofpoint-ORIG-GUID: B1LAtmLIyp-IMo3w2qZMBg12w6c_9u38 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-10_16,2023-07-06_02,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 mlxscore=0 bulkscore=0 phishscore=0 malwarescore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 suspectscore=0 mlxlogscore=698 adultscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307100201 X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Jul 10, 2023 at 03:10:21PM -0500, Segher Boessenkool wrote: > Hi! > > On Mon, Jul 10, 2023 at 03:59:44PM -0400, Michael Meissner wrote: > > In doing other work, I noticed that there was an insn: > > > > vsx_extract_v4sf__load > > > > Which did not have an iterator. I removed the useless . > > This patch does that, you mean. > > > --- a/gcc/config/rs6000/vsx.md > > +++ b/gcc/config/rs6000/vsx.md > > @@ -3576,7 +3576,7 @@ (define_insn_and_split "vsx_extract_v4sf" > > [(set_attr "length" "8") > > (set_attr "type" "fp")]) > > > > -(define_insn_and_split "*vsx_extract_v4sf__load" > > +(define_insn_and_split "*vsx_extract_v4sf_load" > > [(set (match_operand:SF 0 "register_operand" "=f,v,v,?r") > > (vec_select:SF > > (match_operand:V4SF 1 "memory_operand" "m,Z,m,m") > > Does this fix any ICEs? Or do you have some example that makes better > machine code after this change? Or would a better change perhaps be to > just remove this pattern completely, if it doesn't do anything useful? > > I.e., please include a new testcase. There is absolutely no code change. It is purely a cleanup patch. In doing other patches, I just noticed that pattern had a _ in it when it didn't have an iterator. I just cleaned up the code removing _. I probably should have changed it to vsx_extract_v4sf_sf_load. -- Michael Meissner, IBM PO Box 98, Ayer, Massachusetts, USA, 01432 email: meissner@linux.ibm.com