From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 47C953858C66 for ; Wed, 19 Jul 2023 10:51:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 47C953858C66 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689763881; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=HO7d2USN09H1azs3VhxO2AAUSM8KLIgBVMONqi1jePw=; b=OHb9IMEWkftLaL68WJLzXQXQ8dqdPitqazvBiRr8yN5RxNbLG/MoHTLowKfz4hZ2YqSroT I0t9AUKW6omTYWo52DJ/tsiie+R4ymLl1ddHIa/IgBMzAYk1gnClOUnHIhrW3Xer/f8Mqu vr9krUSRrhjdIzrOqEqTInc2r+8X38o= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-558-CJ_2emSwNriBlgLLL5lFXQ-1; Wed, 19 Jul 2023 06:51:20 -0400 X-MC-Unique: CJ_2emSwNriBlgLLL5lFXQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9847D8F1843; Wed, 19 Jul 2023 10:51:19 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.226.176]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A203492B01; Wed, 19 Jul 2023 10:51:19 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 36JApGCX2591137 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 19 Jul 2023 12:51:17 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 36JApFAk2591136; Wed, 19 Jul 2023 12:51:15 +0200 Date: Wed, 19 Jul 2023 12:51:15 +0200 From: Jakub Jelinek To: Hongtao Liu Cc: Uros Bizjak , liuhongt , gcc-patches@gcc.gnu.org, hjl.tools@gmail.com Subject: Re: [PATCH 1/2] [i386] Support type _Float16/__bf16 independent of SSE2. Message-ID: Reply-To: Jakub Jelinek References: <20230421135347.2519452-1-hongtao.liu@intel.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jul 19, 2023 at 01:58:21PM +0800, Hongtao Liu wrote: > > LGTM, if you need someone to rubber-stamp the patch. I'm not really > > versed in this part of the compiler, so please wait a day if someone > > has anything to say about the patch. > Thanks, pushed to trunk. I see some regressions most likely with this change on i686-linux, in particular: +FAIL: gcc.dg/pr107547.c (test for excess errors) +FAIL: gcc.dg/torture/floatn-convert.c -O0 (test for excess errors) +UNRESOLVED: gcc.dg/torture/floatn-convert.c -O0 compilation failed to produce executable +FAIL: gcc.dg/torture/floatn-convert.c -O1 (test for excess errors) +UNRESOLVED: gcc.dg/torture/floatn-convert.c -O1 compilation failed to produce executable +FAIL: gcc.dg/torture/floatn-convert.c -O2 (test for excess errors) +UNRESOLVED: gcc.dg/torture/floatn-convert.c -O2 compilation failed to produce executable +FAIL: gcc.dg/torture/floatn-convert.c -O2 -flto (test for excess errors) +UNRESOLVED: gcc.dg/torture/floatn-convert.c -O2 -flto compilation failed to produce executable +FAIL: gcc.dg/torture/floatn-convert.c -O2 -flto -flto-partition=none (test for excess errors) +UNRESOLVED: gcc.dg/torture/floatn-convert.c -O2 -flto -flto-partition=none compilation failed to produce executable +FAIL: gcc.dg/torture/floatn-convert.c -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions (test for excess errors) +UNRESOLVED: gcc.dg/torture/floatn-convert.c -O3 -fomit-frame-pointer -funroll-loops -fpeel-loops -ftracer -finline-functions compilation failed to produce executable +FAIL: gcc.dg/torture/floatn-convert.c -O3 -g (test for excess errors) +UNRESOLVED: gcc.dg/torture/floatn-convert.c -O3 -g compilation failed to produce executable +FAIL: gcc.dg/torture/floatn-convert.c -Os (test for excess errors) +UNRESOLVED: gcc.dg/torture/floatn-convert.c -Os compilation failed to produce executable +FAIL: gcc.target/i386/float16-7.c (test for errors, line 7) Perhaps we need to tweak gcc/testsuite/lib/target-supports.exp (add_options_for_float16) so that it adds -msse2 for i?86-*-* x86_64-*-* (that would likely fix up floatn-convert) and for the others perhaps /* { dg-add-options float16 } */ ? Jakub