From: Marek Polacek <polacek@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Patrick Palka <ppalka@redhat.com>
Subject: Re: [PATCH] c++: -Wmissing-field-initializers and empty class [PR110064]
Date: Wed, 19 Jul 2023 15:40:57 -0400 [thread overview]
Message-ID: <ZLg8SeChv/CNnSnz@redhat.com> (raw)
In-Reply-To: <f046ec6b-f484-717d-4642-6cae9ebf7009@redhat.com>
On Wed, Jul 19, 2023 at 03:36:49PM -0400, Jason Merrill wrote:
> On 7/19/23 15:20, Marek Polacek wrote:
> > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk?
>
> OK. We might also improve the diagnostic for base classes, perhaps by
> teaching dump_simple_decl about DECL_FIELD_IS_BASE?
As in, instead of "D::<anonymous>" emit "D::B"? Good idea. I suppose
I could do that; Barry's testcase without this patch looks like a good
test case. Thanks,
Marek
prev parent reply other threads:[~2023-07-19 19:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 19:20 Marek Polacek
2023-07-19 19:36 ` Jason Merrill
2023-07-19 19:40 ` Marek Polacek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLg8SeChv/CNnSnz@redhat.com \
--to=polacek@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=ppalka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).