From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 41DE83858C2B for ; Wed, 19 Jul 2023 19:41:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41DE83858C2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689795663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aVvvmoq7QCCbS/1SEs8okh3DVeYS+XpCQGyX5s5hDHg=; b=M1vDD3CrJ01OfOrIeb91BgTjpAgPBKegov6PH/1xhbfxsIzTu+UR4IiHz7O7E7fuP5mL5O DCpRVcUxtKTyepxEVqg33rZvKGEWxqeHQtNMh1Tlm3de6hR3qo5FJoFZPnXh3qaUfs30xo sDagvPw8Axgo6jVy/0X+vr1+B+/hgEE= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-342-ekgBfrpYOA6b3Uo5mqdfcA-1; Wed, 19 Jul 2023 15:41:00 -0400 X-MC-Unique: ekgBfrpYOA6b3Uo5mqdfcA-1 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7659b44990eso6164885a.1 for ; Wed, 19 Jul 2023 12:41:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689795659; x=1692387659; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aVvvmoq7QCCbS/1SEs8okh3DVeYS+XpCQGyX5s5hDHg=; b=Ea1d8Uj63XXJbWM8Evnimd09gwMIpkj6LomKZ/O7WCvQH2WwPdkDR0A7QtnESCqGUn A1NeEIK0zjYtbvLYDUCLUKKYNrram1BLqbF+tiCJWvqvzpQcklciMO6pFNi1bjGtf7sB 71ANGyBTXr+13L9hdpdv43Dqz6p9mSB+O96c9uJUpgPgABjeOFGQ+lhlDrrDdtyX6RTk B4C6uLhPN9DPsKBPraxO7751qdUhVYYx3wd6tgaZ3RkfxLbv1o2SnBn7c6/HtrSgzv81 uutiDjJ/jkIpKUH+nC4ggrI3dvMhMinzfxnc35gPDaUf/K6lnSIYOwBg1BcMjkP8w/dP ijnw== X-Gm-Message-State: ABy/qLbBDjcrpCehJUahh0bjm2k99xh9WXH308sCiInoEGkg9K45l5gI XiNXSOMddF0JfaO7+/kfEYjJBMaulwMaH2AT6KMQWXNneZrQ1/+4ZV0uZbehpWDhBVRkRPHqf60 4Sc3KV4K53YlHGscXUA== X-Received: by 2002:a05:620a:3708:b0:767:df5f:c6b9 with SMTP id de8-20020a05620a370800b00767df5fc6b9mr4702745qkb.2.1689795659694; Wed, 19 Jul 2023 12:40:59 -0700 (PDT) X-Google-Smtp-Source: APBJJlHgngoez+TKapu6zqJzSIGZ0/Rn5F5Aj+/n0yK/XETNvOenNiXg0/X/71NgRs7Mi1JQR1fAqw== X-Received: by 2002:a05:620a:3708:b0:767:df5f:c6b9 with SMTP id de8-20020a05620a370800b00767df5fc6b9mr4702729qkb.2.1689795659418; Wed, 19 Jul 2023 12:40:59 -0700 (PDT) Received: from redhat.com (2603-7000-9500-34a5-0000-0000-0000-1db4.res6.spectrum.com. [2603:7000:9500:34a5::1db4]) by smtp.gmail.com with ESMTPSA id h18-20020a05620a10b200b00765ab6d3e81sm1452904qkk.122.2023.07.19.12.40.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Jul 2023 12:40:59 -0700 (PDT) Date: Wed, 19 Jul 2023 15:40:57 -0400 From: Marek Polacek To: Jason Merrill Cc: GCC Patches , Patrick Palka Subject: Re: [PATCH] c++: -Wmissing-field-initializers and empty class [PR110064] Message-ID: References: <20230719192047.449259-1-polacek@redhat.com> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jul 19, 2023 at 03:36:49PM -0400, Jason Merrill wrote: > On 7/19/23 15:20, Marek Polacek wrote: > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > OK. We might also improve the diagnostic for base classes, perhaps by > teaching dump_simple_decl about DECL_FIELD_IS_BASE? As in, instead of "D::" emit "D::B"? Good idea. I suppose I could do that; Barry's testcase without this patch looks like a good test case. Thanks, Marek