From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6339D3858C2B for ; Thu, 20 Jul 2023 14:08:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6339D3858C2B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1689862101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mk3SIdJaqxyLa9it5CXPwS5jU4ksZWDUatgDXXeYtwU=; b=QdIic7fWCKizF399CTDPKMF8pCT+DC2O5QohC0YXFJMirCPHtYv1YHlM5XdE6I7AN4QlUv jOLVx3qnMTDCcZJ0nXqN7rDHg9S31eo1gsY49eCRAJpHMFu2rQZV58/WexHGUlNm2Eoj+9 tHc8ldQDy2ja+h1cLLvhsVm4k892bfA= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-EWBiP_vMM_yZ2Wj4KFYzuw-1; Thu, 20 Jul 2023 10:08:19 -0400 X-MC-Unique: EWBiP_vMM_yZ2Wj4KFYzuw-1 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-635eeb952b8so11003186d6.3 for ; Thu, 20 Jul 2023 07:08:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689862098; x=1690466898; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mk3SIdJaqxyLa9it5CXPwS5jU4ksZWDUatgDXXeYtwU=; b=COu4P2b4KJjPxGRpGlJbzM7qxrfTZu0/Dpn2rHvFOAKKy8mZBqpTr90w7eQdroFYV+ JRVFGqxZIG9ksG6oPJhvunNxtttYUAGRs9S2I37r5mjod6oLwM1NgCVrAbHkf141qNzG xFQKwau7u3lmvN23+sERsdX8m3DHvSGAfBHhZ59z9oDOPBI3PXQwMUHxfnZEU57JlkWS o8OQkEM//68t3PODa3FqwzjhDZExkMDtsPfwkdtjK1AmV7goHI7b0TXQHEfQMBbp7VZ/ 2/IdF40SMO38+/R5Cuw232KhU1mi2e3TfnHFqoHzPUqTnvEP7CYMi/ucoHxxlSjMQ+kQ ysKQ== X-Gm-Message-State: ABy/qLbeR2xlyZ6fmxinxpBYAgNLY9Nm8wHavRmVEEq+pExvQ7U8FCfE xROxu+4k/N9YrliRIwKUwkVGrOrmSMkoZTvL+zQF7byL9lLIt2DAI9M/1qNzDMlBpm+Q0+1PHrn jK1GMgFlOy83clwUfZA== X-Received: by 2002:a0c:eb49:0:b0:630:198c:3c60 with SMTP id c9-20020a0ceb49000000b00630198c3c60mr21940315qvq.23.1689862097835; Thu, 20 Jul 2023 07:08:17 -0700 (PDT) X-Google-Smtp-Source: APBJJlEmcQlYYbPLjVOadrnZ10Lp9mMqH2/I4bQ2t/J8xXojo722+gSSzTJQaOYZgXOntUIbqbbABQ== X-Received: by 2002:a0c:eb49:0:b0:630:198c:3c60 with SMTP id c9-20020a0ceb49000000b00630198c3c60mr21940296qvq.23.1689862097578; Thu, 20 Jul 2023 07:08:17 -0700 (PDT) Received: from redhat.com (2603-7000-9500-34a5-0000-0000-0000-1db4.res6.spectrum.com. [2603:7000:9500:34a5::1db4]) by smtp.gmail.com with ESMTPSA id x20-20020a0cb214000000b00626362f1bf1sm370392qvd.63.2023.07.20.07.08.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jul 2023 07:08:17 -0700 (PDT) Date: Thu, 20 Jul 2023 10:08:15 -0400 From: Marek Polacek To: Jason Merrill Cc: Patrick Palka , GCC Patches Subject: [PATCH v2] c++: fix ICE with designated initializer [PR110114] Message-ID: References: <20230719180053.46101-1-polacek@redhat.com> <3efd2e0c-1c18-de91-4708-dfd1892ecb11@idea> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Jul 19, 2023 at 03:24:10PM -0400, Jason Merrill wrote: > On 7/19/23 14:38, Marek Polacek wrote: > > On Wed, Jul 19, 2023 at 02:32:15PM -0400, Patrick Palka wrote: > > > On Wed, 19 Jul 2023, Marek Polacek wrote: > > > > > > > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > > > > > LGTM. It might be preferable to check COMPLETE_TYPE_P in the caller > > > instead, so that we avoid inspecting CLASSTYPE_NON_AGGREGATE on an > > > incomplete class type, and so that the caller doesn't "commit" to > > > building an aggregate conversion. > > > > Perhaps. I wanted to avoid the call to build_user_type_conversion_1. > > I could add an early return to implicit_conversion_1 but I'd have to > > move some code around not to check COMPLETE_TYPE_P before complete_type. > > Maybe return NULL for the incomplete case here, rather than just skipping > reshape_init? > > /* Call reshape_init early to remove redundant braces. */ > if (expr && BRACE_ENCLOSED_INITIALIZER_P (expr) > && CLASS_TYPE_P (to) > && COMPLETE_TYPE_P (complete_type (to)) > && !CLASSTYPE_NON_AGGREGATE (to)) > { > expr = reshape_init (to, expr, complain); > if (expr == error_mark_node) > return NULL; > from = TREE_TYPE (expr); > } > > If that doesn't work, the patch is fine as-is. It does work, with one test tweak (which I don't think is a regression): Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? -- >8 -- r13-1227 added an assert checking that the index in a CONSTRUCTOR is a FIELD_DECL. That's a reasonable assumption but in this case we never called reshape_init due to the type being incomplete, and so the index remained an identifier node: get_class_binding never got around to looking up the FIELD_DECL. We can avoid the crash by returning early in implicit_conversion_1; we'd return NULL anyway due to: if (i < CONSTRUCTOR_NELTS (ctor)) return NULL; in build_aggr_conv. PR c++/110114 gcc/cp/ChangeLog: * call.cc (implicit_conversion_1): Return early if the type isn't complete. gcc/testsuite/ChangeLog: * g++.dg/cpp0x/initlist100.C: Adjust expected diagnostic. * g++.dg/cpp2a/desig28.C: New test. * g++.dg/cpp2a/desig29.C: New test. --- gcc/cp/call.cc | 19 +++++++++++-------- gcc/testsuite/g++.dg/cpp0x/initlist100.C | 4 ++-- gcc/testsuite/g++.dg/cpp2a/desig28.C | 17 +++++++++++++++++ gcc/testsuite/g++.dg/cpp2a/desig29.C | 10 ++++++++++ 4 files changed, 40 insertions(+), 10 deletions(-) create mode 100644 gcc/testsuite/g++.dg/cpp2a/desig28.C create mode 100644 gcc/testsuite/g++.dg/cpp2a/desig29.C diff --git a/gcc/cp/call.cc b/gcc/cp/call.cc index b55230d98aa..673ec91d60e 100644 --- a/gcc/cp/call.cc +++ b/gcc/cp/call.cc @@ -2059,15 +2059,18 @@ implicit_conversion_1 (tree to, tree from, tree expr, bool c_cast_p, complain &= ~tf_error; /* Call reshape_init early to remove redundant braces. */ - if (expr && BRACE_ENCLOSED_INITIALIZER_P (expr) - && CLASS_TYPE_P (to) - && COMPLETE_TYPE_P (complete_type (to)) - && !CLASSTYPE_NON_AGGREGATE (to)) + if (expr && BRACE_ENCLOSED_INITIALIZER_P (expr) && CLASS_TYPE_P (to)) { - expr = reshape_init (to, expr, complain); - if (expr == error_mark_node) - return NULL; - from = TREE_TYPE (expr); + to = complete_type (to); + if (!COMPLETE_TYPE_P (to)) + return nullptr; + if (!CLASSTYPE_NON_AGGREGATE (to)) + { + expr = reshape_init (to, expr, complain); + if (expr == error_mark_node) + return nullptr; + from = TREE_TYPE (expr); + } } if (TYPE_REF_P (to)) diff --git a/gcc/testsuite/g++.dg/cpp0x/initlist100.C b/gcc/testsuite/g++.dg/cpp0x/initlist100.C index 9d80a004c17..6865d34a6f9 100644 --- a/gcc/testsuite/g++.dg/cpp0x/initlist100.C +++ b/gcc/testsuite/g++.dg/cpp0x/initlist100.C @@ -2,9 +2,9 @@ // { dg-do compile { target c++11 } } namespace std { -template class initializer_list; // { dg-message "declaration" } +template class initializer_list; } template struct B { B (std::initializer_list); }; struct C { virtual int foo (); }; -struct D : C {} d { B { D {} } }; // { dg-error "incomplete|no matching" } +struct D : C {} d { B { D {} } }; // { dg-error "no matching" } diff --git a/gcc/testsuite/g++.dg/cpp2a/desig28.C b/gcc/testsuite/g++.dg/cpp2a/desig28.C new file mode 100644 index 00000000000..b63265fea51 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp2a/desig28.C @@ -0,0 +1,17 @@ +// PR c++/110114 +// { dg-do compile { target c++20 } } + +struct A { + int a,b; +}; + +struct B; + +void foo(const A &) {} +void foo(const B &) {} + +int +main () +{ + foo({.a=0}); +} diff --git a/gcc/testsuite/g++.dg/cpp2a/desig29.C b/gcc/testsuite/g++.dg/cpp2a/desig29.C new file mode 100644 index 00000000000..bd1a82b041d --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp2a/desig29.C @@ -0,0 +1,10 @@ +// PR c++/110114 +// { dg-do compile { target c++20 } } + +struct B; + +void foo(const B &) {} + +int main() { + foo({.a=0}); // { dg-error "invalid" } +} base-commit: b86c0fe327a5196a316bd698d12765b08de5dce7 -- 2.41.0