public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Michael Meissner <meissner@linux.ibm.com>
To: "Kewen.Lin" <linkw@linux.ibm.com>
Cc: Michael Meissner <meissner@linux.ibm.com>,
	gcc-patches@gcc.gnu.org,
	Segher Boessenkool <segher@kernel.crashing.org>,
	David Edelsohn <dje.gcc@gmail.com>,
	Peter Bergner <bergner@linux.ibm.com>
Subject: Re: [PATCH] Fix typo in insn name.
Date: Wed, 26 Jul 2023 17:53:06 -0400	[thread overview]
Message-ID: <ZMGVwi/vRXtJxjaP@cowardly-lion.the-meissners.org> (raw)
In-Reply-To: <b4760b38-0d29-dbcc-0c59-b5b0af26f22e@linux.ibm.com>

On Wed, Jul 26, 2023 at 01:54:01PM +0800, Kewen.Lin wrote:
> Hi Mike,
> 
> on 2023/7/11 03:59, Michael Meissner wrote:
> > In doing other work, I noticed that there was an insn:
> > 
> > 	vsx_extract_v4sf_<mode>_load
> > 
> > Which did not have an iterator.  I removed the useless <mode>.
> 
> It actually has a mode iterator, the "P" is used for clobber.
> 
> The whole pattern of this define_insn_and_split is
> 
> (define_insn_and_split "*vsx_extract_v4sf_<mode>_load"
>   [(set (match_operand:SF 0 "register_operand" "=f,v,v,?r")
> 	(vec_select:SF
> 	 (match_operand:V4SF 1 "memory_operand" "m,Z,m,m")
> 	 (parallel [(match_operand:QI 2 "const_0_to_3_operand" "n,n,n,n")])))
>    (clobber (match_scratch:P 3 "=&b,&b,&b,&b"))]         <== *P used here*
> 
> Its definition is:
> 
> (define_mode_iterator P [(SI "TARGET_32BIT") (DI "TARGET_64BIT")])
> 
> I guess we can just leave it there?
> 
> BR,
> Kewen

Yes, I didn't notice the :P in the insn.

-- 
Michael Meissner, IBM
PO Box 98, Ayer, Massachusetts, USA, 01432
email: meissner@linux.ibm.com

      reply	other threads:[~2023-07-26 21:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-10 19:59 Michael Meissner
2023-07-10 20:10 ` Segher Boessenkool
2023-07-10 22:25   ` Michael Meissner
2023-07-24 18:44 ` Ping: " Michael Meissner
2023-07-26  5:54 ` Kewen.Lin
2023-07-26 21:53   ` Michael Meissner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMGVwi/vRXtJxjaP@cowardly-lion.the-meissners.org \
    --to=meissner@linux.ibm.com \
    --cc=bergner@linux.ibm.com \
    --cc=dje.gcc@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=linkw@linux.ibm.com \
    --cc=segher@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).