From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DB2963860765 for ; Fri, 18 Aug 2023 16:40:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DB2963860765 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692376826; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=+WhuYK87Qslu/yX0hQ4IG+RhGx4T7Fuj7CmFcerchzw=; b=ZLoBgd9NoMijaAhiuWZsTX2FmliRTEOzburkpJ6R6pq+OH0JfYwM/rAlB0U1AiXISYEbRD YjVyKAy2IIG2n/BkChwoh8i0zFrBbo8X0weghJQ6VMLSvIHHQEXLwV9b4Cr2jO53MijG62 4TZcVDM8Gvvn3bD9fvuntjm7OcqLhsg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-467-G22BOQCsPi2K797J0wPFfw-1; Fri, 18 Aug 2023 12:40:25 -0400 X-MC-Unique: G22BOQCsPi2K797J0wPFfw-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C4FCA80006E; Fri, 18 Aug 2023 16:40:24 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 89F1BC15BAD; Fri, 18 Aug 2023 16:40:24 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 37IGeLT3011047 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Fri, 18 Aug 2023 18:40:22 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 37IGeLEg011046; Fri, 18 Aug 2023 18:40:21 +0200 Date: Fri, 18 Aug 2023 18:40:20 +0200 From: Jakub Jelinek To: "Jose E. Marchesi" Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Emit funcall external declarations only if actually used. Message-ID: Reply-To: Jakub Jelinek References: <20230818135351.9177-1-jose.marchesi@oracle.com> <87sf8gtir5.fsf@oracle.com> MIME-Version: 1.0 In-Reply-To: <87sf8gtir5.fsf@oracle.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_STOCKGEN,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Fri, Aug 18, 2023 at 06:31:10PM +0200, Jose E. Marchesi wrote: > > This won't work if target can't use a direct call instruction. > > Consider > > __int128 a, b; void foo () { a = a / b; } > > on x86_64-linux. With just -O2, the above works fine, with > > -O2 -mcmodel=large it will not, the call is indirect, but at least one has > > REG_CALL_DECL note that could be used as fallback to the above. > > And with -O0 -mcmodel=large because flag_ipa_ra is false REG_CALL_DECL isn't > > emitted at all. > > So, perhaps you could emit the REG_CALL_DECL note even if !flag_ipa_ra > > when SYMBOL_REF_LIBCALL is set? > > Hmm something like this? Yes. Jakub