From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch] omp-expand.cc: Fix wrong code with non-rectangular loop nest [PR111017]
Date: Fri, 18 Aug 2023 19:25:25 +0200 [thread overview]
Message-ID: <ZN+phVuSpfrpUoyp@tucnak> (raw)
In-Reply-To: <07c94dde-f513-0177-51d7-05267694f383@codesourcery.com>
On Fri, Aug 18, 2023 at 07:15:16PM +0200, Tobias Burnus wrote:
> Comments, questions, concerns?
>
> If not, I intent to commit the attached patch to mainline on Monday
> and after the usual grace time to GCC 13 and then to GCC 12.
>
> PR middle-end/111017
> gcc/
> * omp-expand.cc (expand_omp_for_init_vars): Pass after=true
> to expand_omp_build_cond for 'factor != 0' condition, resulting
> in pre-r12-5295-g47de0b56ee455e code for the gimple insert.
>
> libgomp/
> * testsuite/libgomp.c-c++-common/non-rect-loop-1.c: New test.
LGTM, thanks.
Jakub
prev parent reply other threads:[~2023-08-18 17:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-18 17:15 Tobias Burnus
2023-08-18 17:25 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN+phVuSpfrpUoyp@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).