From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 4EE113858284 for ; Mon, 7 Aug 2023 21:22:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4EE113858284 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691443353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yfnf7hetKdyARG0DdrJXqpcHJzNO352S7N/6SyWWMVc=; b=Tb756NnVmEH1JMXdFxNpGKqYGuVN9oria/TUAbqAqK1zC7lFkWYHjEl5G/apqsIliEumTW lFPKh48txQZRjqo/Se3rUgrlTVDFe5cGJHBwsKWzHJWPZz3K5t+80+Uu3QzwrVznhgvWKz 2vYo5QfI90DvTDYOydvG5hgi/BnkxHI= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-3-gHsKNDnrNaOqgBIfyJllYw-1; Mon, 07 Aug 2023 17:22:32 -0400 X-MC-Unique: gHsKNDnrNaOqgBIfyJllYw-1 Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-40fd444be73so68628131cf.3 for ; Mon, 07 Aug 2023 14:22:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691443336; x=1692048136; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Yfnf7hetKdyARG0DdrJXqpcHJzNO352S7N/6SyWWMVc=; b=L+AT9O6apXvW04eahVQXyuwqHIWCzl/lGnm9qgutJS0l0I36JbCx+4+sKjVPGBth6Q BO8XPRsj7Y2gDqgfoFHUJbTJX2hVjBaTiUn2BKrugI/KSmQLbzTW63q2g2yJ5YuT0KFp DViqMDjsTIw4QIsW8SrDL43W5w/1JfnbFPZM4n8SjLE8S/PbUT1nwicRwX6qJ7oAD2R+ YRMdmFyUXRh20esgfy9AqwDcH4d7+AAoZ5OaFnaU82a0IzwesnllAqtlBLUyWzYb8rG4 lkyoX6yFSf/VW/p9n7PMCC4oHfJ3K7ud61pJ18o1+4Z2B7LdVCZdZ0ec/eHTojzQzRmJ 4mDg== X-Gm-Message-State: AOJu0Yz89llXGgYRg04Y3uXMzuIO6CQYiNEiyxsvsNJN1zlgFouqFq3x tBOgEnvZKCdxk05XZwRa+NmN5wNUv73JMEAzmvDYLRhenCjt7nqcpP3DTPeVGl147Nvqu8E/oVS uWsl7/PDKtPX7VXlROg== X-Received: by 2002:ac8:5c4f:0:b0:40c:8f5d:1b3 with SMTP id j15-20020ac85c4f000000b0040c8f5d01b3mr15423727qtj.41.1691443336482; Mon, 07 Aug 2023 14:22:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyylX9ZZNd4vPSDSvFLRAJCIf1ImFRghPWAbtHB05ynIDxSa2SunUvNJGfCld3gLFw1CwuUw== X-Received: by 2002:ac8:5c4f:0:b0:40c:8f5d:1b3 with SMTP id j15-20020ac85c4f000000b0040c8f5d01b3mr15423716qtj.41.1691443336276; Mon, 07 Aug 2023 14:22:16 -0700 (PDT) Received: from redhat.com (2603-7000-9500-34a5-0000-0000-0000-1db4.res6.spectrum.com. [2603:7000:9500:34a5::1db4]) by smtp.gmail.com with ESMTPSA id iw2-20020a05622a6f8200b00403f5873f5esm2869953qtb.24.2023.08.07.14.22.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Aug 2023 14:22:15 -0700 (PDT) Date: Mon, 7 Aug 2023 17:22:14 -0400 From: Marek Polacek To: Jonathan Wakely Cc: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [committed] i386: Fix grammar typo in diagnostic Message-ID: References: <20230807211335.701619-1-jwakely@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230807211335.701619-1-jwakely@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Aug 07, 2023 at 10:12:35PM +0100, Jonathan Wakely via Gcc-patches wrote: > Committed as obvious. > > Less obvious (to me) is whether it's correct to say "GCC V13" here. I > don't think we refer to a version that way anywhere else, do we? > > Would "since GCC 13.1.0" be better? x86_field_alignment uses inform (input_location, "the alignment of %<_Atomic %T%> " "fields changed in %{GCC 11.1%}", so maybe the below should use %{GCC 13.1%}. "GCC V13" looks unusual to me. > -- >8 -- > > gcc/ChangeLog: > > * config/i386/i386.cc (ix86_invalid_conversion): Fix grammar. > --- > gcc/config/i386/i386.cc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc > index 50860050049..5d57726e22c 100644 > --- a/gcc/config/i386/i386.cc > +++ b/gcc/config/i386/i386.cc > @@ -22890,7 +22890,7 @@ ix86_invalid_conversion (const_tree fromtype, const_tree totype) > warning (0, "%<__bfloat16%> is redefined from typedef % " > "to real %<__bf16%> since GCC V13, be careful of " > "implicit conversion between %<__bf16%> and %; " > - "a explicit bitcast may be needed here"); > + "an explicit bitcast may be needed here"); > } > > /* Conversion allowed. */ > -- > 2.41.0 > Marek