From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id C35043858D20 for ; Thu, 10 Aug 2023 10:28:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C35043858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691663309; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=saFHGgqOlCg58RlQkekxhMenZxF+cu4CGjtf7pQcvus=; b=EaCK+9+I/xfUTShN5DBUXGKoT2Z6TX2mN6DGP+BdcaRWX34xlnFnpR8AFx7A2RCEVfPkpH 76KN8vy2pkiTWfst4Hh0IFmKOAGS1nIVVvTveOMyUFUPIYQ5dxNJwBwD8sWsuUfjXy42dh ntoSO7TP9RXhnpYvAhEIA0roA3TictU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-681-xx0437SrOku8W61-OgFraA-1; Thu, 10 Aug 2023 06:28:28 -0400 X-MC-Unique: xx0437SrOku8W61-OgFraA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DC275805AF6; Thu, 10 Aug 2023 10:28:27 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.13]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A0BFE2166B25; Thu, 10 Aug 2023 10:28:27 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 37AASPRq2069467 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 10 Aug 2023 12:28:25 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 37AASOgD2069466; Thu, 10 Aug 2023 12:28:24 +0200 Date: Thu, 10 Aug 2023 12:28:24 +0200 From: Jakub Jelinek To: Richard Biener Cc: Drew Ross , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] match.pd: Implement missed optimization ((x ^ y) & z) | x -> (z & y) | x [PR109938] Message-ID: Reply-To: Jakub Jelinek References: <20230804214817.1256642-1-drross@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Aug 08, 2023 at 03:18:51PM +0200, Richard Biener via Gcc-patches wrote: > On Fri, Aug 4, 2023 at 11:49 PM Drew Ross via Gcc-patches > wrote: > > > > Adds a simplification for ((x ^ y) & z) | x to be folded into > > (z & y) | x. Merges this simplification with ((x | y) & z) | x -> (z & y) | x > > to prevent duplicate pattern. Tested successfully on x86_64 and x86 targets. > > OK. Shouldn't (bit_ior:c (bit_and:cs (bit_ior:cs @0 @1) @2) @0) be changed to (bit_ior:c (nop_convert1?:s (bit_and:cs (nop_convert2?:s (op:cs @0 @1)) @2)) @3) rather than (bit_ior:c (nop_convert1? (bit_and:c (nop_convert2? (op:c @0 @1)) @2)) @3) in the patch? I mean the :s modifiers were there for a reason, if some of the intermediates aren't a single use, then the simplification doesn't simplify anything and can even make things larger. Jakub