From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: FX Coudert <fxcoudert@gmail.com>, GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] libgomp, testsuite: Do not call nonstandard functions on darwin
Date: Mon, 21 Aug 2023 21:41:06 +0200 [thread overview]
Message-ID: <ZOO90u6c3ak1o2hc@tucnak> (raw)
In-Reply-To: <c8e1f156-990d-ce98-2428-e1777d0ec7d3@codesourcery.com>
On Mon, Aug 21, 2023 at 09:12:09PM +0200, Tobias Burnus wrote:
> OK. — I'd prefer if you also changed + tested a fix for my (a) + (b)
> remarks, but as those are unrelated, I understand if you don't and just
> commit your Darwin patch.
I don't like the #if !defined(__APPLE__) conditionals everywhere in the
test, I think much cleaner would be to add an effective target to test
for those functions (ideally that calls to all of them link;
all of them at once) and then use
{ dg-additional-options "-DWHATEVER" { target whatever } }
and use #ifdef WHATEVER conditionals instead.
That way any other target which doesn't have all these will not suffer from
it.
Jakub
next prev parent reply other threads:[~2023-08-21 19:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-20 19:37 FX Coudert
2023-08-21 19:12 ` Tobias Burnus
2023-08-21 19:41 ` Jakub Jelinek [this message]
2023-08-21 19:50 ` FX Coudert
2023-08-21 19:55 ` Jakub Jelinek
2023-08-21 20:00 ` FX Coudert
2023-08-21 20:11 ` Jakub Jelinek
2023-08-22 8:16 ` FX Coudert
2023-08-22 8:23 ` Jakub Jelinek
2023-08-22 8:25 ` FX Coudert
2023-08-22 17:10 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOO90u6c3ak1o2hc@tucnak \
--to=jakub@redhat.com \
--cc=fxcoudert@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).