From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id B73853858D37 for ; Mon, 21 Aug 2023 19:41:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B73853858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692646874; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g7jSOu/j62oC+SQgbSV5yUOWSdii5dOSSjb5tE0rkTQ=; b=XCZKWbi7h7wrfYIeLhzvxWSX5QOXJWXtaoNWh6uGYCh9LePObFbgMjQDqH9GshSIXdNyN3 iFQL+KnBE9ohitQlx9eWvJhOEC4Schykuafx4Zx0Kcr6CQ31i/+cF4TV4N74GraPGheZEv Nw9NH6Y9bNfGI0pcbiK3BiMk0BvjNkA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-401-E2OvhQpgMt6AsHgmvJ5GoQ-1; Mon, 21 Aug 2023 15:41:11 -0400 X-MC-Unique: E2OvhQpgMt6AsHgmvJ5GoQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A5D48800CAE; Mon, 21 Aug 2023 19:41:10 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6A081492C13; Mon, 21 Aug 2023 19:41:10 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 37LJf7ST063703 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 21 Aug 2023 21:41:08 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 37LJf6qX063702; Mon, 21 Aug 2023 21:41:06 +0200 Date: Mon, 21 Aug 2023 21:41:06 +0200 From: Jakub Jelinek To: Tobias Burnus Cc: FX Coudert , GCC Patches Subject: Re: [PATCH] libgomp, testsuite: Do not call nonstandard functions on darwin Message-ID: Reply-To: Jakub Jelinek References: <1B1BFD2E-20FB-4A33-A96D-78872595C416@gmail.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Aug 21, 2023 at 09:12:09PM +0200, Tobias Burnus wrote: > OK. — I'd prefer if you also changed + tested a fix for my (a) + (b) > remarks, but as those are unrelated, I understand if you don't and just > commit your Darwin patch. I don't like the #if !defined(__APPLE__) conditionals everywhere in the test, I think much cleaner would be to add an effective target to test for those functions (ideally that calls to all of them link; all of them at once) and then use { dg-additional-options "-DWHATEVER" { target whatever } } and use #ifdef WHATEVER conditionals instead. That way any other target which doesn't have all these will not suffer from it. Jakub