From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 1D1E13858D37 for ; Mon, 21 Aug 2023 19:55:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1D1E13858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692647737; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=rHq/UUEjsIHer/a5ZpU7FLy4HakZpoD1TMihd8fbnhk=; b=FtKk2v1FgXWV0GBbOvF5KskKeG6dA3eGQwKJVdJKFANN32RmODCUKuI5dUnWiOH8HgC3HM Ebbjad0YDu3+UonrA0x6Fka9vyD8k0Z7tceNHMkdNT60rc1kgMNX1pzElO38Y5Py6MZF0A +k6gMiWRsi0FGKM41JPKEmY9tuACGXg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-661-Bl8eSfNmO0qlf_uZ36v3sQ-1; Mon, 21 Aug 2023 15:55:36 -0400 X-MC-Unique: Bl8eSfNmO0qlf_uZ36v3sQ-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 017DC185A793; Mon, 21 Aug 2023 19:55:36 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.224.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B3C2040C206F; Mon, 21 Aug 2023 19:55:35 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 37LJtXhr063737 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Mon, 21 Aug 2023 21:55:33 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 37LJtWCm063736; Mon, 21 Aug 2023 21:55:32 +0200 Date: Mon, 21 Aug 2023 21:55:32 +0200 From: Jakub Jelinek To: FX Coudert Cc: Tobias Burnus , GCC Patches Subject: Re: [PATCH] libgomp, testsuite: Do not call nonstandard functions on darwin Message-ID: Reply-To: Jakub Jelinek References: <1B1BFD2E-20FB-4A33-A96D-78872595C416@gmail.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Mon, Aug 21, 2023 at 09:50:37PM +0200, FX Coudert wrote: > > I don't like the #if !defined(__APPLE__) conditionals everywhere in the > > test, I think much cleaner would be to add an effective target to test > > for those functions > > I understand, I wanted to not just report the issue but propose an option. It seems a bit heavy to design an effective target just for one test, though, no? It has the advantage of getting it right on all current and future targets. > Another possibility would be to replace #if !defined(__APPLE__) by #if defined(__linux__), or glibc? If we do it, I'd still prefer one specific macro for all those spots, TEST_NONSTANDARD_MATH_FNS or whatever and then at the start of the test you can do either #if !defined(__APPLE__) or #if defined(__linux__) or whatever else around its definition. That has the advantage of only touching one spot if one wants to add or remove those on some other target. Jakub