From: Jakub Jelinek <jakub@redhat.com>
To: Sandra Loosemore <sandra@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH V2 4/5] OpenMP: New C/C++ testcases for imperfectly nested loops.
Date: Tue, 22 Aug 2023 15:34:46 +0200 [thread overview]
Message-ID: <ZOS5dgA/h2yuxDYl@tucnak> (raw)
In-Reply-To: <20230723221521.3739463-5-sandra@codesourcery.com>
On Sun, Jul 23, 2023 at 04:15:20PM -0600, Sandra Loosemore wrote:
> gcc/testsuite/ChangeLog
> * c-c++-common/gomp/imperfect-attributes.c: New.
> * c-c++-common/gomp/imperfect-badloops.c: New.
> * c-c++-common/gomp/imperfect-blocks.c: New.
> * c-c++-common/gomp/imperfect-extension.c: New.
> * c-c++-common/gomp/imperfect-gotos.c: New.
> * c-c++-common/gomp/imperfect-invalid-scope.c: New.
> * c-c++-common/gomp/imperfect-labels.c: New.
> * c-c++-common/gomp/imperfect-legacy-syntax.c: New.
> * c-c++-common/gomp/imperfect-pragmas.c: New.
> * c-c++-common/gomp/imperfect1.c: New.
> * c-c++-common/gomp/imperfect2.c: New.
> * c-c++-common/gomp/imperfect3.c: New.
> * c-c++-common/gomp/imperfect4.c: New.
> * c-c++-common/gomp/imperfect5.c: New.
>
> libgomp/ChangeLog
> * testsuite/libgomp.c-c++-common/imperfect1.c: New.
> * testsuite/libgomp.c-c++-common/imperfect2.c: New.
> * testsuite/libgomp.c-c++-common/imperfect3.c: New.
> * testsuite/libgomp.c-c++-common/imperfect4.c: New.
> * testsuite/libgomp.c-c++-common/imperfect5.c: New.
> * testsuite/libgomp.c-c++-common/imperfect6.c: New.
> * testsuite/libgomp.c-c++-common/target-imperfect1.c: New.
> * testsuite/libgomp.c-c++-common/target-imperfect2.c: New.
> * testsuite/libgomp.c-c++-common/target-imperfect3.c: New.
> * testsuite/libgomp.c-c++-common/target-imperfect4.c: New.
As I wrote in reply to the cover letter, I'd prefer the
ordered(2)/ordered(3) nests to have #pragma omp ordered doacross(source:)
and #pragma omp ordered doacross(sink: ...) directives and
use the libgomp scan-1.c as basis for the scan tests.
Otherwise LGTM.
Jakub
next prev parent reply other threads:[~2023-08-22 13:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-23 22:15 [PATCH V2 0/5] OpenMP: support for imperfectly-nested loops Sandra Loosemore
2023-07-23 22:15 ` [PATCH V2 1/5] OpenMP: Add OMP_STRUCTURED_BLOCK and GIMPLE_OMP_STRUCTURED_BLOCK Sandra Loosemore
2023-08-22 13:01 ` Jakub Jelinek
2023-07-23 22:15 ` [PATCH V2 2/5] OpenMP: C front end support for imperfectly-nested loops Sandra Loosemore
2023-08-22 13:23 ` Jakub Jelinek
2023-08-22 18:53 ` Sandra Loosemore
2023-08-24 11:49 ` Jakub Jelinek
2023-07-23 22:15 ` [PATCH V2 3/5] OpenMP: C++ " Sandra Loosemore
2023-08-22 13:31 ` Jakub Jelinek
2023-07-23 22:15 ` [PATCH V2 4/5] OpenMP: New C/C++ testcases for imperfectly nested loops Sandra Loosemore
2023-08-22 13:34 ` Jakub Jelinek [this message]
2023-07-23 22:15 ` [PATCH V2 5/5] OpenMP: Fortran support for imperfectly-nested loops Sandra Loosemore
2023-08-22 13:37 ` Jakub Jelinek
2023-08-24 16:36 ` Tobias Burnus
2023-08-22 12:56 ` [PATCH V2 0/5] OpenMP: " Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOS5dgA/h2yuxDYl@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=sandra@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).