From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 991403858D1E for ; Tue, 22 Aug 2023 13:34:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 991403858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1692711292; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=t7RezqKclJGbPyMxZcdVgKZ+3P3kUmWqZnxoVFR4Dok=; b=JaHp7vqUYS/J54BTvtCKPc5TeVhq8PU3Rp2YZlzVMnmpivW/ApVRV4HgMBZ7WC4rI3QXoH nsyLnJ05JvU+gljXIQev9Uns2+BNGXM4x5f+83dPiGCSEl9OIani9b1ZOdkQFnXIKPplon /cMhfvugCNvzMXs4EvMhWGz3dZ8v7MU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-611-uXDFksPvO6iw6U1-OS9Bhg-1; Tue, 22 Aug 2023 09:34:50 -0400 X-MC-Unique: uXDFksPvO6iw6U1-OS9Bhg-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9E25D1991C40; Tue, 22 Aug 2023 13:34:48 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.45.225.165]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6218D1121314; Tue, 22 Aug 2023 13:34:48 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 37MDYkqv2439468 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Tue, 22 Aug 2023 15:34:46 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 37MDYkUj2439465; Tue, 22 Aug 2023 15:34:46 +0200 Date: Tue, 22 Aug 2023 15:34:46 +0200 From: Jakub Jelinek To: Sandra Loosemore Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH V2 4/5] OpenMP: New C/C++ testcases for imperfectly nested loops. Message-ID: Reply-To: Jakub Jelinek References: <20230723221521.3739463-1-sandra@codesourcery.com> <20230723221521.3739463-5-sandra@codesourcery.com> MIME-Version: 1.0 In-Reply-To: <20230723221521.3739463-5-sandra@codesourcery.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Sun, Jul 23, 2023 at 04:15:20PM -0600, Sandra Loosemore wrote: > gcc/testsuite/ChangeLog > * c-c++-common/gomp/imperfect-attributes.c: New. > * c-c++-common/gomp/imperfect-badloops.c: New. > * c-c++-common/gomp/imperfect-blocks.c: New. > * c-c++-common/gomp/imperfect-extension.c: New. > * c-c++-common/gomp/imperfect-gotos.c: New. > * c-c++-common/gomp/imperfect-invalid-scope.c: New. > * c-c++-common/gomp/imperfect-labels.c: New. > * c-c++-common/gomp/imperfect-legacy-syntax.c: New. > * c-c++-common/gomp/imperfect-pragmas.c: New. > * c-c++-common/gomp/imperfect1.c: New. > * c-c++-common/gomp/imperfect2.c: New. > * c-c++-common/gomp/imperfect3.c: New. > * c-c++-common/gomp/imperfect4.c: New. > * c-c++-common/gomp/imperfect5.c: New. > > libgomp/ChangeLog > * testsuite/libgomp.c-c++-common/imperfect1.c: New. > * testsuite/libgomp.c-c++-common/imperfect2.c: New. > * testsuite/libgomp.c-c++-common/imperfect3.c: New. > * testsuite/libgomp.c-c++-common/imperfect4.c: New. > * testsuite/libgomp.c-c++-common/imperfect5.c: New. > * testsuite/libgomp.c-c++-common/imperfect6.c: New. > * testsuite/libgomp.c-c++-common/target-imperfect1.c: New. > * testsuite/libgomp.c-c++-common/target-imperfect2.c: New. > * testsuite/libgomp.c-c++-common/target-imperfect3.c: New. > * testsuite/libgomp.c-c++-common/target-imperfect4.c: New. As I wrote in reply to the cover letter, I'd prefer the ordered(2)/ordered(3) nests to have #pragma omp ordered doacross(source:) and #pragma omp ordered doacross(sink: ...) directives and use the libgomp scan-1.c as basis for the scan tests. Otherwise LGTM. Jakub