From: Jakub Jelinek <jakub@redhat.com>
To: Tobias Burnus <tobias@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Patch] OpenMP (C only): omp allocate - extend parsing support, improve diagnostic
Date: Tue, 12 Sep 2023 09:15:07 +0200 [thread overview]
Message-ID: <ZQAP+8ZHElOxWoa+@tucnak> (raw)
In-Reply-To: <6083ff90-1bb2-41de-a353-369859a1a69b@codesourcery.com>
On Tue, Sep 12, 2023 at 09:04:16AM +0200, Tobias Burnus wrote:
> Done now. What's not caught is, e.g., a value change by calling a
> function which modifies its parameter:
>
> omp_allocator_t a = ...; int v; foo(a); #pragma omp allocate(v) allocator(a)
>
> as the current check is only whether 'a' is declared before 'v' or
> whether 'a' is assigned to between v's declaration and the pragma.
>
> Any additional comments or suggestions?
As I said, we can't catch all the mistakes, the unfortunate thing is that
the syntax allows them. I'll try to make omp::decl attribute working soon
and that will make that problem less severe when using that syntax.
Jakub
next prev parent reply other threads:[~2023-09-12 7:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 16:12 [Patch] OpenMP (C only): omp allocate - handle stack vars, " Tobias Burnus
2023-08-29 16:28 ` Jakub Jelinek
2023-08-29 16:56 ` Tobias Burnus
2023-08-29 17:14 ` Jakub Jelinek
2023-08-30 10:47 ` Tobias Burnus
2023-08-30 11:13 ` Jakub Jelinek
2023-08-30 12:43 ` Tobias Burnus
2023-09-11 11:44 ` [Patch] OpenMP (C only): omp allocate - extend parsing support, improve diagnostic (was: [Patch] OpenMP (C only): omp allocate - handle stack vars, improve diagnostic) Tobias Burnus
2023-09-11 11:54 ` Jakub Jelinek
2023-09-11 13:07 ` David Malcolm
2023-09-11 13:21 ` Tobias Burnus
2023-09-11 13:34 ` Jakub Jelinek
2023-09-12 7:04 ` [Patch] OpenMP (C only): omp allocate - extend parsing support, improve diagnostic Tobias Burnus
2023-09-12 7:15 ` Jakub Jelinek [this message]
2023-09-12 8:55 ` Tobias Burnus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZQAP+8ZHElOxWoa+@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=tobias@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).