From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A2B3E3858439 for ; Tue, 12 Sep 2023 17:34:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2B3E3858439 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694540088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OWHhP6uCbh3yyhWf86nPkcS4gmslOAl3pNQ5C+zj1cc=; b=CiTbl2LnlrSIYOrpNm0f521HTWcwpQ3gbaJLVA05e99Ft06hFWy2S1xd4gtKgZYbl78bJG hyenf45+GDIXQZfu1s/pxEO5K4Hy93Q4B+dGOkeCi4tJFeFe1vawsTvxmHOzfoNbhnEemo S/RnlM4M2Uo6L/TufOujDT+f0pVAJx4= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-370-7uu4CmzYNPOrCSrJKO8mXA-1; Tue, 12 Sep 2023 13:34:46 -0400 X-MC-Unique: 7uu4CmzYNPOrCSrJKO8mXA-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-655d8978597so39014156d6.2 for ; Tue, 12 Sep 2023 10:34:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694540086; x=1695144886; h=user-agent:in-reply-to:content-disposition:mime-version:references :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OWHhP6uCbh3yyhWf86nPkcS4gmslOAl3pNQ5C+zj1cc=; b=L6IF/mIldrQwCwy3IyEhaZmvtdRiqIvpIeuNeDM0qALt4j5PxVUcvqz2euC3Ao8WbH /1++nCHvnKz17gnV1p/dxUL7F3zuTbf290uc1PdM58oldit83C07pkvKzkyYniv7OR6L Se5CXUM2N2mcBvi2WmIHblb4eIF5/ArcH6K2gO0oY9w35zksbTvCskG3KruHsFH2MIjq jcguV24tUHfyiW9WI0DwtIkVoWhLS4pSEvIdBRV9oGsBWflp9cStzCBT55SEFUlfq9CL XWplMPb6Xo1hxrAUVuNStaiUeVV1V7TsLwMLDmdyysaJOvV2IEGjcJjgYzlhnck2Bx2X 24qg== X-Gm-Message-State: AOJu0YxBAcMlpibfbScbR0DNY5GJola/yoWyV9oYDDF666NIa7v5qvJp aCAOpYXRK1gVVxlDdVKaW9Cf7DfkGK2U/BZ8/+X+UDxP9wLZvySsqr4nkDtkBpfDvmdcmD+3bF0 G6H8DZLc31NJsYtUOHrizBYMoTQ== X-Received: by 2002:a0c:ea2a:0:b0:649:af66:e828 with SMTP id t10-20020a0cea2a000000b00649af66e828mr123434qvp.45.1694540086155; Tue, 12 Sep 2023 10:34:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfF67Bnz5527ghOavzXB+kYVmMkAOhxGWiDiFLti7yhAT4xgdChMUxdgV9idLrbN8AfZSPxQ== X-Received: by 2002:a0c:ea2a:0:b0:649:af66:e828 with SMTP id t10-20020a0cea2a000000b00649af66e828mr123418qvp.45.1694540085865; Tue, 12 Sep 2023 10:34:45 -0700 (PDT) Received: from redhat.com (2603-7000-9500-34a5-0000-0000-0000-1db4.res6.spectrum.com. [2603:7000:9500:34a5::1db4]) by smtp.gmail.com with ESMTPSA id qj10-20020a056214320a00b00655f35dcbcasm1385937qvb.75.2023.09.12.10.34.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Sep 2023 10:34:45 -0700 (PDT) Date: Tue, 12 Sep 2023 13:34:43 -0400 From: Marek Polacek To: Jason Merrill Cc: gcc-patches@gcc.gnu.org Subject: Re: [pushed] c++: __integer_pack with class argument [PR111357] Message-ID: References: <20230912172744.1930180-1-jason@redhat.com> MIME-Version: 1.0 In-Reply-To: <20230912172744.1930180-1-jason@redhat.com> User-Agent: Mutt/2.2.9 (2022-11-12) X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, Sep 12, 2023 at 01:27:44PM -0400, Jason Merrill via Gcc-patches wrote: > Tested x86_64-pc-linux-gnu, applying to trunk. > > -- 8< -- > > The argument might not already be an integer. > > PR c++/111357 > > gcc/cp/ChangeLog: > > * pt.cc (expand_integer_pack): Convert argument to int. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/integer-pack7.C: New test. > --- > gcc/cp/pt.cc | 2 ++ > gcc/testsuite/g++.dg/ext/integer-pack7.C | 38 ++++++++++++++++++++++++ > 2 files changed, 40 insertions(+) > create mode 100644 gcc/testsuite/g++.dg/ext/integer-pack7.C > > diff --git a/gcc/cp/pt.cc b/gcc/cp/pt.cc > index 838179d5fe3..b583c11eb99 100644 > --- a/gcc/cp/pt.cc > +++ b/gcc/cp/pt.cc > @@ -3793,6 +3793,8 @@ expand_integer_pack (tree call, tree args, tsubst_flags_t complain, > } > else > { > + hi = perform_implicit_conversion_flags (integer_type_node, hi, complain, > + LOOKUP_IMPLICIT); FWIW, we have perform_implicit_conversion for this. Marek