From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 0130B385841A for ; Wed, 4 Oct 2023 16:57:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0130B385841A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696438638; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=f6IttnN+sfZ105J13axicyWFABjR0d/X7pMOLfZfeI4=; b=EVO/R7MFgHhcUVKEiWCNHP/RZ0GLPaDAxMoCept5pHE/Nn6yjrf1sNMXClDK0i8MjaUxbj ZT7AL8wx+jmy6scWnkZJlWgngXIv94l3jBJxAHMltPEAAr1J4VbxeM9xjxKZp+igk2qu0T xeyBBMPp0wGeiwxpeHZ9t8m8h/HuFro= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-632-iX7VhfW4OACa0mJcYERWRQ-1; Wed, 04 Oct 2023 12:57:17 -0400 X-MC-Unique: iX7VhfW4OACa0mJcYERWRQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2A9088007A4; Wed, 4 Oct 2023 16:57:17 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DFB85140E950; Wed, 4 Oct 2023 16:57:16 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 394GvEGX1818187 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 4 Oct 2023 18:57:14 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 394GvDLd1818186; Wed, 4 Oct 2023 18:57:13 +0200 Date: Wed, 4 Oct 2023 18:57:13 +0200 From: Jakub Jelinek To: Pranav Kant Cc: Jonathan Wakely , Stephan Bergmann , libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [committed] libstdc++: Define std::numeric_limits<_FloatNN> before C++23 Message-ID: Reply-To: Jakub Jelinek References: <20230817203213.1131496-1-jwakely@redhat.com> <097e48f1-b915-4d6c-b68e-8ee282bc6de5@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Oct 04, 2023 at 09:47:34AM -0700, Pranav Kant wrote: > Thanks for bringing this to my attention. I am working on a fix. Will keep > this thread posted. > > Clang *does* define this macro only when float128 type is available. But > the problem seems to be that clang doesn't define _Float128 alias type > which is what's being used here. It only defines __float128 type. Should be > easy to fix. _Float128 (and other _FloatNN types) are standard C23 and C++23 types, they certainly can't be simple aliases to __float128 or other similar types. In C++ they mangle differently, have significantly different behavior in lots of different language details. So, you need to implement the https://wg21.link/P1467R9 paper, rather than doing quick hacks. Jakub