From: Jakub Jelinek <jakub@redhat.com>
To: Jan Hubicka <hubicka@ucw.cz>
Cc: Martin Jambor <mjambor@suse.cz>,
Richard Biener <rguenther@suse.de>,
Aldy Hernandez <aldyh@redhat.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] ipa: Remove ipa_bits
Date: Thu, 5 Oct 2023 16:59:28 +0200 [thread overview]
Message-ID: <ZR7PUH3CMZp6RaXO@tucnak> (raw)
In-Reply-To: <ZR7LYk8XJ0Z1HKsP@kam.mff.cuni.cz>
On Thu, Oct 05, 2023 at 04:42:42PM +0200, Jan Hubicka wrote:
> It does look like a nice cleanup to me.
> I wonder if you did some compare of the bit information propagated with
> new code and old code? Theoretically they should be equivalent?
Beyond testsuite, I've tried
__attribute__((noinline, noclone)) static int
foo (int x, int y, int *p)
{
return p[x + y];
}
__attribute__((noinline, noclone)) static int
bar (int x, int y, int *p)
{
return foo (x, y & 0xff, p);
}
int
baz (int x, int y, int *p)
{
return bar ((x & 0x55555555) | 0x12345678, (x & 0xaaaaaaaa) | 0x87654321, __builtin_assume_aligned (p, 32, 16));
}
and -fdump-tree-ccp2-alias was identical before/after the patch,
so the expected
# RANGE [irange] int [305419896, +INF] MASK 0x45410105 VALUE 0x12345678
int x_5(D) = x;
# RANGE [irange] int [0, 255] MASK 0x8a VALUE 0x21
int y_6(D) = y;
# PT = nonlocal null
# ALIGN = 32, MISALIGN = 16
int * p_7(D) = p;
in foo (-O2). With -O2 -fno-ipa-vrp
# RANGE [irange] int [-INF, +INF] MASK 0x45410105 VALUE 0x12345678
int x_5(D) = x;
# RANGE [irange] int [-INF, +INF] MASK 0x8a VALUE 0x21
int y_6(D) = y;
# PT = nonlocal null
# ALIGN = 32, MISALIGN = 16
int * p_7(D) = p;
and -O2 -fno-ipa-bit-cp
# RANGE [irange] int [305419896, +INF] MASK 0x45410105 VALUE 0x12345678
int x_5(D) = x;
# RANGE [irange] int [0, 255] MASK 0x8a VALUE 0x21
int y_6(D) = y;
# PT = nonlocal null
int * p_7(D) = p;
All that is the same as before.
Jakub
next prev parent reply other threads:[~2023-10-05 14:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 12:26 Jakub Jelinek
2023-10-05 14:06 ` Aldy Hernandez
2023-10-05 14:42 ` Jan Hubicka
2023-10-05 14:59 ` Jakub Jelinek [this message]
2023-10-06 5:54 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZR7PUH3CMZp6RaXO@tucnak \
--to=jakub@redhat.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=mjambor@suse.cz \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).