From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6424E38618D2 for ; Thu, 5 Oct 2023 14:59:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6424E38618D2 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696517975; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=hgMGjlXMGVoysuyK0fU6SIp8yW7bE2MnMbG9eW8l71M=; b=VqGiKowQ+OMG+pn17izmS91QralFMu4RuOHcaM9w54xGeguPkgz4iAirU7rEWhD3m+pZqq fV6F6IQcQBK2cBWsz9DiZR5bU/CiWYUSWQvr9CzeKIYl6vPXnOyuHPczXOh45dv42jXrEH 2+JQVaVhVJyF0tT9O6Y5UT9hZKtqGRU= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-206-ySH2SumNOD6GtmNebu-frA-1; Thu, 05 Oct 2023 10:59:33 -0400 X-MC-Unique: ySH2SumNOD6GtmNebu-frA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4FDA51C05EA2; Thu, 5 Oct 2023 14:59:33 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.193.202]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0F004170EE; Thu, 5 Oct 2023 14:59:32 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 395ExTKV505379 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Thu, 5 Oct 2023 16:59:30 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 395ExS7S505378; Thu, 5 Oct 2023 16:59:28 +0200 Date: Thu, 5 Oct 2023 16:59:28 +0200 From: Jakub Jelinek To: Jan Hubicka Cc: Martin Jambor , Richard Biener , Aldy Hernandez , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] ipa: Remove ipa_bits Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, Oct 05, 2023 at 04:42:42PM +0200, Jan Hubicka wrote: > It does look like a nice cleanup to me. > I wonder if you did some compare of the bit information propagated with > new code and old code? Theoretically they should be equivalent? Beyond testsuite, I've tried __attribute__((noinline, noclone)) static int foo (int x, int y, int *p) { return p[x + y]; } __attribute__((noinline, noclone)) static int bar (int x, int y, int *p) { return foo (x, y & 0xff, p); } int baz (int x, int y, int *p) { return bar ((x & 0x55555555) | 0x12345678, (x & 0xaaaaaaaa) | 0x87654321, __builtin_assume_aligned (p, 32, 16)); } and -fdump-tree-ccp2-alias was identical before/after the patch, so the expected # RANGE [irange] int [305419896, +INF] MASK 0x45410105 VALUE 0x12345678 int x_5(D) = x; # RANGE [irange] int [0, 255] MASK 0x8a VALUE 0x21 int y_6(D) = y; # PT = nonlocal null # ALIGN = 32, MISALIGN = 16 int * p_7(D) = p; in foo (-O2). With -O2 -fno-ipa-vrp # RANGE [irange] int [-INF, +INF] MASK 0x45410105 VALUE 0x12345678 int x_5(D) = x; # RANGE [irange] int [-INF, +INF] MASK 0x8a VALUE 0x21 int y_6(D) = y; # PT = nonlocal null # ALIGN = 32, MISALIGN = 16 int * p_7(D) = p; and -O2 -fno-ipa-bit-cp # RANGE [irange] int [305419896, +INF] MASK 0x45410105 VALUE 0x12345678 int x_5(D) = x; # RANGE [irange] int [0, 255] MASK 0x8a VALUE 0x21 int y_6(D) = y; # PT = nonlocal null int * p_7(D) = p; All that is the same as before. Jakub