From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id A2A5A3858D37 for ; Wed, 8 Nov 2023 16:05:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2A5A3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A2A5A3858D37 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699459523; cv=none; b=hzI04KooCbOjC00L/5sx/JUZYm7V2PHMeQCSwrXXKxfvo0ABijRmDYeajMil9r6xiUIpXZGZTcf2cNNVuFLKx8eE+vMP3mmU7dNaZEKJNYIFZtL/Ep7yFOcscVEXHn87CI7LvScApZPcIAOBW/bIks5HIyGtAjWYINsHQ98VegI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1699459523; c=relaxed/simple; bh=3gieUeCNE+KW3lRks9cOQXYoO+iTPZyRej25WUEKjOw=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=KwP3iiTHc0yU7ijg0lTBYrim6Wrflq9j2SKuwZg9KabwlqaUvD3eYDsrQ/+2EsfhKBv8IqUu0O4yja3VtMbcTJJCGNIlUxKNih59+NAY1FgNwxS4qiN5LGWEL2q3I45S+VhDidGe0dil7Q6e0dO7LFbfQJaqotr4n4uuhVHHmwY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1699459517; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=kmPsYoUdhdvQDRByDTZTI/lQ2BeBpsCLu5mg3t+QmIE=; b=Z3T7gqY5L5nU62MDWvVGSeJBrgpdjqZRMG4z5pxNF8TS1BgfQUgsyXaFNGdhlixL5KOger L4N+tJaVF8HVDeyOHnPMMfDh9m8aKLTRAICrYPosH4zetOw2gywUDTgHmhVYtbgxwyQAjO fiPAEpgJGyebXU5gejqpvpXcYG0kL40= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-HiwiwVovNBmbGTEXnvgt4w-1; Wed, 08 Nov 2023 11:05:13 -0500 X-MC-Unique: HiwiwVovNBmbGTEXnvgt4w-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id CDF1482BA8A; Wed, 8 Nov 2023 16:05:10 +0000 (UTC) Received: from tucnak.zalov.cz (unknown [10.39.192.81]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A6982166B27; Wed, 8 Nov 2023 16:05:10 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.17.1/8.17.1) with ESMTPS id 3A8G57V4124471 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Wed, 8 Nov 2023 17:05:07 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.17.1/8.17.1/Submit) id 3A8G55ed124469; Wed, 8 Nov 2023 17:05:05 +0100 Date: Wed, 8 Nov 2023 17:05:05 +0100 From: Jakub Jelinek To: Alexandre Oliva Cc: gcc-patches@gcc.gnu.org, Rainer Orth , Mike Stump Subject: Re: [PATCH] testsuite: adjust gomp test for x86 -m32 Message-ID: Reply-To: Jakub Jelinek References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, Nov 08, 2023 at 12:56:44PM -0300, Alexandre Oliva wrote: > > declare-target-3.C expects .quad for entries in offload_var_table, but > the entries are pointer-wide, so 32-bit targets use .long instead. > Accept both. > > Regstrapped on x86_64-linux-gnu, also tested with gcc-13 on i686- and > x86_64-. Ok to install? > > for gcc/testsuite/ChangeLog > > * g++.dg/gomp/declare-target-3.C: Adjust for 32-bit targets. Ok (though, I wonder if it isn't sa .4byte or .8byte etc. on even other targets). > --- a/gcc/testsuite/g++.dg/gomp/declare-target-3.C > +++ b/gcc/testsuite/g++.dg/gomp/declare-target-3.C > @@ -22,10 +22,10 @@ int *g = &f; // Explicitly marked > // { dg-final { scan-tree-dump "__attribute__\\\(\\\(omp declare target\\\)\\\)\\\nint bar \\\(\\\)" "gimple" } } > // { dg-final { scan-tree-dump "__attribute__\\\(\\\(omp declare target\\\)\\\)\\\nint baz \\\(\\\)" "gimple" } } > // { dg-final { scan-tree-dump "__attribute__\\\(\\\(omp declare target\\\)\\\)\\\nint qux \\\(\\\)" "gimple" } } > -// { dg-final { scan-assembler-not "\\\.offload_var_table:\\n.+\\\.quad\\s+a" { target { offloading_enabled } } } } > -// { dg-final { scan-assembler "\\\.offload_var_table:\\n.+\\\.quad\\s+b" { target { offloading_enabled } } } } > -// { dg-final { scan-assembler "\\\.offload_var_table:\\n.+\\\.quad\\s+c" { target { offloading_enabled } } } } > -// { dg-final { scan-assembler "\\\.offload_var_table:\\n.+\\\.quad\\s+d" { target { offloading_enabled } } } } > -// { dg-final { scan-assembler "\\\.offload_var_table:\\n.+\\\.quad\\s+e" { target { offloading_enabled } } } } > -// { dg-final { scan-assembler "\\\.offload_var_table:\\n.+\\\.quad\\s+f" { target { offloading_enabled } } } } > -// { dg-final { scan-assembler "\\\.offload_var_table:\\n.+\\\.quad\\s+g" { target { offloading_enabled } } } } > +// { dg-final { scan-assembler-not "\\\.offload_var_table:\\n.+\\\.(quad|long)\\s+a" { target { offloading_enabled } } } } > +// { dg-final { scan-assembler "\\\.offload_var_table:\\n.+\\\.(quad|long)\\s+b" { target { offloading_enabled } } } } > +// { dg-final { scan-assembler "\\\.offload_var_table:\\n.+\\\.(quad|long)\\s+c" { target { offloading_enabled } } } } > +// { dg-final { scan-assembler "\\\.offload_var_table:\\n.+\\\.(quad|long)\\s+d" { target { offloading_enabled } } } } > +// { dg-final { scan-assembler "\\\.offload_var_table:\\n.+\\\.(quad|long)\\s+e" { target { offloading_enabled } } } } > +// { dg-final { scan-assembler "\\\.offload_var_table:\\n.+\\\.(quad|long)\\s+f" { target { offloading_enabled } } } } > +// { dg-final { scan-assembler "\\\.offload_var_table:\\n.+\\\.(quad|long)\\s+g" { target { offloading_enabled } } } } Jakub