From: Jan Hubicka <hubicka@ucw.cz>
To: Alexandre Oliva <oliva@adacore.com>
Cc: Jonathan Wakely <jwakely.gcc@gmail.com>,
gcc-patches@gcc.gnu.org, Nathan Sidwell <nathan@acm.org>,
Eric Botcazou <ebotcazou@adacore.com>,
"Joseph S. Myers" <joseph@codesourcery.com>
Subject: Re: [PATCH v5] Introduce attribute sym_alias (was: Last call for bikeshedding on attribute sym/exalias/reverse_alias)
Date: Wed, 22 Nov 2023 14:13:37 +0100 [thread overview]
Message-ID: <ZV3+gUyLrF5JVgeu@kam.mff.cuni.cz> (raw)
In-Reply-To: <orzg1he65o.fsf_-_@lxoliva.fsfla.org>
Hi,
it seems that interface to symbol table is fairly minimal here reduced
to...
> (create_sym_alias_decl, create_sym_alias_decls): New.
> * cgraphunit.cc (cgraph_node::analyze): Create alias_target
> node if needed.
called from here...
> (analyze_functions): Fixup visibility of implicit alias only
> after its node is analyzed.
> + if (VAR_P (replaced))
> + varpool_node::create_extra_name_alias (sym_node->decl, replacement);
> + else
> + cgraph_node::create_same_body_alias (sym_node->decl, replacement);
I wonder why you use same body aliases, which are kind of special to C++
frontend (and come with fixup code working around its quirks you had to
disable above).
Why you do not produce usual alias attribute once you know the symbol
table so it goes the cgraph_node::create_alias or
vaprool_node::create_alias path?
Honza
next prev parent reply other threads:[~2023-11-22 13:13 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-29 20:56 [RFC, WIP] introduce attribute exalias Alexandre Oliva
2020-08-07 17:38 ` [PATCH] " Alexandre Oliva
2020-08-14 15:39 ` Alexandre Oliva
2020-08-14 16:24 ` Nathan Sidwell
2020-08-14 19:24 ` Alexandre Oliva
2020-08-14 22:12 ` Nathan Sidwell
2020-08-15 2:43 ` Alexandre Oliva
2020-08-15 9:22 ` Iain Sandoe
2020-08-15 16:39 ` Alexandre Oliva
2020-08-15 18:17 ` Iain Sandoe
2020-08-25 8:34 ` Alexandre Oliva
2020-08-25 11:23 ` Iain Sandoe
2020-08-15 17:26 ` Alexandre Oliva
2020-08-15 21:11 ` Nathan Sidwell
2020-08-25 7:50 ` Alexandre Oliva
2023-07-15 1:08 ` [PATCH v3] Introduce attribute reverse_alias Alexandre Oliva
2023-07-15 21:55 ` Nathan Sidwell
2023-07-18 4:29 ` Alexandre Oliva
2023-07-18 11:37 ` Richard Biener
2023-07-19 23:11 ` [PATCH v4] Introduce attribute sym Alexandre Oliva
2023-07-20 13:09 ` Richard Biener
2023-07-21 9:23 ` Alexandre Oliva
2023-07-22 3:12 ` Fangrui Song
2023-08-16 4:27 ` Alexandre Oliva
[not found] ` <orpm2tgrsd.fsf_-_@lxoliva.fsfla.org>
[not found] ` <CAH6eHdQ3vT3MjohuE-izto+K=BMRykY3T-UyWa5-=OTDPM-JsQ@mail.gmail.com>
[not found] ` <ory1h9t6nr.fsf@lxoliva.fsfla.org>
2023-09-20 5:59 ` [PATCH v5] Introduce attribute sym_alias (was: Last call for bikeshedding on attribute sym/exalias/reverse_alias) Alexandre Oliva
2023-11-20 12:54 ` [PATCH v5] Introduce attribute sym_alias Alexandre Oliva
2023-11-22 12:14 ` Richard Biener
2023-11-22 19:16 ` Joseph Myers
2023-11-22 13:13 ` Jan Hubicka [this message]
2023-11-30 12:53 ` [PATCH v6] " Alexandre Oliva
2023-11-30 15:24 ` Jan Hubicka
2023-12-01 11:25 ` [PATCH v7] " Alexandre Oliva
2023-12-06 2:10 ` [PATCH v8] " Alexandre Oliva
2023-12-06 10:06 ` [PATCH v7] " Jan Hubicka
2023-12-07 20:52 ` Alexandre Oliva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV3+gUyLrF5JVgeu@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=jwakely.gcc@gmail.com \
--cc=nathan@acm.org \
--cc=oliva@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).